2015211 - Add logging to JsepTrack

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Adding jsep debug logging to JsepTrack.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 2015211 - add logging to jseptrack;r=bwc

Let's get ahead of the upcoming changes to the assert guidance and
start logging everywhere we are asserting. We can use this logging
to guide the discussion on which of these functions to make failable.

We should also do this for JsepSessionImpl, etc.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f8789fabbfdd
https://hg.mozilla.org/integration/autoland/rev/59cf8e0d4d7e
add logging to jseptrack;r=bwc

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/59cf8e0d4d7e

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 9544354 [details]
Bug 2015211 - add logging to jseptrack;r=bwc

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Improved debugging of WebRTC negotiation failures.
• User impact if declined: Greater difficulty in diagnosing WebRTC negotiation failures.
• Fix Landed on Version: 149
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a logging improvement that doesn't change behavior

Comment 5

[Pascal Chevrel (relman team) -> :pascalc]

Nico, your patch does not apply cleanly to the esr140 branch, could you rebase it please? Thanks

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9544354 [details]
Bug 2015211 - add logging to jseptrack;r=bwc

Approved for 140.9esr.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/5ad440c18075