Closed Bug 2015238 Opened 9 months ago Closed 9 months ago

Use private class fields in devtools/client/accessibility/panel.js

Categories

(DevTools :: Accessibility Tools, enhancement, P3)

Product:
DevTools
Component:
Accessibility Tools
Type:
enhancement

Tracking

(firefox149 fixed)

Status:
RESOLVED FIXED
Milestone:
149 Branch
Tracking Flags:
Tracking Status
firefox149 --- fixed

People

(Reporter: cvl123abc, Assigned: cvl123abc)

References

(Depends on 1 open bug)

Details

Attachments

(1 external file, 1 obsolete file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.0.0 Safari/537.36

Steps to reproduce:

Reviewed devtools/client/accessibility/panel.js and identified underscore-prefixed properties and methods that are used as private class members.

Actual results:

The file currently uses underscore-prefixed properties and methods to indicate privacy.

Expected results:

Use JavaScript private class fields and methods (#) instead of underscore-prefixed properties.

Depends on: 2011387

I’m working on this as part of the ongoing private fields migration (meta bug 2011387).

Priority: -- → P3
Assignee: nobody → cvl123abc
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9544295 - Attachment is obsolete: true
Pushed by nchevobbe@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8f615d0ac355 https://hg.mozilla.org/integration/autoland/rev/e6f87b47ef61 Use private fields for AccessibilityPanel and expose toolbox via getter. r=nchevobbe,devtools-reviewers

https://hg.mozilla.org/mozilla-central/rev/e6f87b47ef61

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox149: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: