2015410 - Fix clang-tidy warnings in js/src/builtin/intl and js/src/builtin/temporal

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, task, P3)

Description

[André Bargull [:anba]]

clang-tidy currently doesn't work correctly (bug 2015386), so some warnings went unnoticed, because Phabricator didn't nag about them.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 2015410 - Part 1: Fix clang-tidy warnings in js/src/builtin/intl. r=#spidermonkey-reviewers!

Fixes various clang-tidy warnings, like:

• auto instead of auto.
• Unnecessary explicit initialisation of class members.
• Missing default initialisation of class members.
• length() == 0 instead of empty() tests.
• Missing explicit casts to narrow int types.
• Missing default case in switch statements.
• bool return statements which can be simplified.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 2015410 - Part 2: Fix clang-tidy warnings in js/src/builtin/temporal. r=#spidermonkey-reviewers!

Also fix clang-tidy warnings in "js/src/builtin/temporal".

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d0bbd803fcd
https://hg.mozilla.org/integration/autoland/rev/5cbb2a99ece8
Part 1: Fix clang-tidy warnings in js/src/builtin/intl. r=spidermonkey-reviewers,arai
https://github.com/mozilla-firefox/firefox/commit/1f9af96e8664
https://hg.mozilla.org/integration/autoland/rev/c631abac212f
Part 2: Fix clang-tidy warnings in js/src/builtin/temporal. r=spidermonkey-reviewers,arai

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f42dce2a0f52
https://hg.mozilla.org/integration/autoland/rev/d270382b770b
Revert "Bug 2015410 - Part 2: Fix clang-tidy warnings in js/src/builtin/temporal. r=spidermonkey-reviewers,arai" for causing Calendar.cpp related failures.

Comment 5

[Silaghi Andreea]

Backed out for causing failures in Calendar.cpp
Backout Link
Push with failures
Failure Log
Failure line Assertion failure: 1 <= months && months <= CalendarMonthsPerYear(calendarId), at /builds/worker/checkouts/gecko/js/src/builtin/temporal/Calendar.cpp:X

Comment 6

[André Bargull [:anba]]

Thanks. There was a simple oversight in a new assertion.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/117395f1d500
https://hg.mozilla.org/integration/autoland/rev/296c3299cf8a
Part 1: Fix clang-tidy warnings in js/src/builtin/intl. r=spidermonkey-reviewers,arai
https://github.com/mozilla-firefox/firefox/commit/2501809f40da
https://hg.mozilla.org/integration/autoland/rev/5034f0e96917
Part 2: Fix clang-tidy warnings in js/src/builtin/temporal. r=spidermonkey-reviewers,arai

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/296c3299cf8a
https://hg.mozilla.org/mozilla-central/rev/5034f0e96917