2015655 - WebDriver Bidi does not emulate locale in dedicated and shared workers

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Andrey Lushnikov]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.0.0 Safari/537.36

Steps to reproduce:

• Downstream Playwright bug: https://github.com/microsoft/playwright/issues/38919
• Downstream playwright test: https://github.com/microsoft/playwright/blob/d91dce9170eeec4de22ed4731dce25b26b58c29f/tests/library/browsercontext-locale.spec.ts#L168

Reproduction:

1. clone playwright repo: git clone https://github.com/microsoft/playwright
2. remove the line #169 - the it.fail expectation.
3. Run the test with Firefox Bidi: npm run biditest browsercontext-locale:168 -- --project moz-firefox-nightly-library

Actual results:

The test fails because WebDriver bidi does not emulate locale in workers.

Expected results:

WebDriver should emulate locale in workers. The test should pass.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Internationalization' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alexandra Borovova [:Sasha]]

For locale emulation of the JS APIs to be picked up by the workers, we have to implement the logic of updating the locale in the realm of the existing and new workers.

For handling of navigator.language in workers, we have bug 1996547.

Comment 3

[Andrey Lushnikov]

Hi folks,

Are there any plans on fixing this? If not, we'll consider migrating away from BiDi-powered api for locale emulation back to the Juggler home-grown implementation.

Comment 4

[Alexandra Borovova [:Sasha]]

(In reply to Andrey Lushnikov from comment #3)

Hi folks,

Are there any plans on fixing this? If not, we'll consider migrating away from BiDi-powered api for locale emulation back to the Juggler home-grown implementation.

Hi!

Yes, it's planned for this quarter (same for timezone), so we should get to it soon.

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 2015655 - Override locale and navigator.language/s in dedicated and shared workers when browsingContext.languageOverride is set in related browsing contexts.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 2015655 - [wdspec] Add tests for overriding locale and navigator.language/s with "emulation.setLocaleOverride" in workers.

Comment 7

[Alexandra Borovova [:Sasha]]

Attachment: Bug 2015655 - Remove unneeded mDefaultLocale from browsingContext.languageOverride setup logic.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/322f939aefce
https://hg.mozilla.org/integration/autoland/rev/36c9a0048fdd
Override locale and navigator.language/s in dedicated and shared workers when browsingContext.languageOverride is set in related browsing contexts. r=dom-worker-reviewers,asuth
https://github.com/mozilla-firefox/firefox/commit/8a76b7d3341e
https://hg.mozilla.org/integration/autoland/rev/d7b3238c6283
Remove unneeded mDefaultLocale from browsingContext.languageOverride setup logic. r=dom-core,smaug
https://github.com/mozilla-firefox/firefox/commit/c4b221f54974
https://hg.mozilla.org/integration/autoland/rev/1e3b4f7b16ad
[wdspec] Add tests for overriding locale and navigator.language/s with "emulation.setLocaleOverride" in workers. r=jdescottes

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/36c9a0048fdd
https://hg.mozilla.org/mozilla-central/rev/d7b3238c6283
https://hg.mozilla.org/mozilla-central/rev/1e3b4f7b16ad

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60269 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot