2015690 - GitHub checks for enterprise-firefox-release links to treeherder enterprise-firefox jobs

Status: RESOLVED FIXED

(Enterprise Products :: General, defect, P2)

Description

[:gerard-majax]

See for example jobs from https://github.com/mozilla/enterprise-firefox/runs/62999985448 that links to https://treeherder.mozilla.org/#/jobs?repo=enterprise-firefox&revision=32211b8bc77b50f7fc2b74a605a95014e719a1fb&selectedTaskRun=WLHEP-xVTXyTR9IgsvpPaA which should be https://treeherder.mozilla.org/#/jobs?repo=enterprise-firefox-release&revision=32211b8bc77b50f7fc2b74a605a95014e719a1fb&selectedTaskRun=WLHEP-xVTXyTR9IgsvpPaA

Comment 1

[:gerard-majax]

Andrew, do you know where this is handled?

Comment 2

[Andrew Halberstadt [:ahal]]

There's an assumption that there's a 1-1 mapping of TC project -> Treeherder project.. which obviously isn't the case in Github with multiple branches.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2015690 - [ci] Refactor 'get_head_ref' to exclude index prefix, r?#taskgraph-reviewers!

We need to get just the 'head_ref' part without the index portion of the
string in order to build the Treeherder links properly.

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2015690 - Support generating Treeherder links in projects with multiple TH branches, r?#taskgraph-reviewers!

Comment 5

[Andrew Halberstadt [:ahal]]

Once the above patches land and get merged to enterprise-main, I'll need to land a commit that adds treeherder.branch-map to enterprise-firefox.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/49047f028ad8
https://hg.mozilla.org/integration/autoland/rev/ec281acb7cb4
[ci] Refactor 'get_head_ref' to exclude index prefix, r=taskgraph-reviewers,jcristau
https://github.com/mozilla-firefox/firefox/commit/d98fac838922
https://hg.mozilla.org/integration/autoland/rev/03986790bdfc
Support generating Treeherder links in projects with multiple TH branches, r=taskgraph-reviewers,jcristau

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6478c4ffadc2
https://hg.mozilla.org/integration/autoland/rev/208a76fcb8a2
Revert "Bug 2015690 - Support generating Treeherder links in projects with multiple TH branches, r=taskgraph-reviewers,jcristau" for cauins python failures

Comment 8

[amarc]

Backed out for causing python failures

• Backout link
• Push with failures
• Failure Log

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2015690 - Use 'treeherder.branch-map' to set Treeherder route, r?#taskgraph-reviewers!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/738f434a2603
https://hg.mozilla.org/integration/autoland/rev/30c496b73a65
[ci] Refactor 'get_head_ref' to exclude index prefix, r=taskgraph-reviewers,jcristau
https://github.com/mozilla-firefox/firefox/commit/df2df9d8b22d
https://hg.mozilla.org/integration/autoland/rev/4fdec57bbff1
Support generating Treeherder links in projects with multiple TH branches, r=taskgraph-reviewers,jcristau

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/30c496b73a65
https://hg.mozilla.org/mozilla-central/rev/4fdec57bbff1

Comment 12

[BMO Github Automation]

Attachment: [mozilla/enterprise-firefox] Bug 2015690 - Use proper Treeherder routes based on current branch (#449)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6c58dac72c7f
https://hg.mozilla.org/integration/autoland/rev/c401f3db2acd
Use 'treeherder.branch-map' to set Treeherder route, r=taskgraph-reviewers,bhearsum

Comment 14

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/c401f3db2acd

Comment 15

[BMO Github Automation]

Authored by https://github.com/ahal
https://github.com/mozilla/enterprise-firefox/commit/25124c7d5cc574754b49c35c33cce097429c58ae
[enterprise-main] Bug 2015690 - Use proper Treeherder routes based on current branch