2015700 - Neither about:translations's source text area nor target language selector focused on page load

Status: NEW

(Firefox :: Translations, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: Screenshot of about:translations with no focused elements on page load

This bug is a regression from bug 1970962 in Fx 145.

I bisected this regression to this push:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e0e73c8c27a31c4056ed83172dbff72d20ef6bff&tochange=82d8e9889fbb40faefe37936c2c3c071a3df6035

Steps to reproduce

1. Click in the address bar.
2. Type translate and select the "Translate" quick action (or just enter about:translations directly).

Expected behavior

Either the source text area or target language selector should be focused.

The target language selector is focused when loading about:translations directly because no target language has been specified. The source text area is focused when about:translations is loaded by the Translate quick action because the quick action defaults the target language to the browser's language.

Actual behavior

Neither the source text area nor target language selector are focused.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 2015700 - Postpone focus until the about:translations UI is visible. r?#translations-reviewers

AboutTranslations's #setInitialFocus() call in #setup() no longer works
after bug 1970962 because the UI is hidden when #setup() is called.

applied. The page is hidden by default: body { visibility: hidden; } in
toolkit/components/translations/content/about-translations.css. The body only
becomes visible in onFeatureEnabled() via document.body.style.visibility =
"visible".