Session History panel isn't notified on title updates
Categories
(DevTools :: Application Panel, defect, P3)
Tracking
(firefox149 fixed)
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: farre, Assigned: farre)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(1 file)
Title updates are made directly on the SessionHistoryEntry, which means that we won't get an update on them. We need to change either the session history listener to allow notifications for this or notify about a session history commit. I think the former is more elegant.
|
Assignee | |
Comment 1•3 months ago
|
||
|
||
Updated•3 months ago
|
|
||
Updated•3 months ago
|
|
||
Comment 3•3 months ago
|
||
| bugherder | ||
|
||
Updated•3 months ago
|
|
||
Comment 4•3 months ago
|
||
(In reply to Pulsebot from comment #2)
Pushed by afarre@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/27c1d1064deb
https://hg.mozilla.org/integration/autoland/rev/863be8134f34
Update DevTools about session history entry title updates.
r=devtools-reviewers,dom-core,smaug,nchevobbe
Perfherder has detected a browsertime performance change from push 863be8134f34ccdc2d9fdf6cdf943ebd953a7a1b.
No action is required from the author; this comment is provided for informational purposes only.
| Improvement | Test | Platform | Options | Absolute values [old vs new] |
|---|---|---|---|---|
| 6% | microsoft-support FirstVisualChange (doc) | android-hw-a55-14-0-aarch64-shippable | warm webrender | 208.35 ms -> 196.48 ms |
| 6% | microsoft-support ContentfulSpeedIndex (doc) | android-hw-a55-14-0-aarch64-shippable | warm webrender | 226.63 ms -> 214.05 ms |
Need Help or Information?
If you have any questions, please reach out to . Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
Description
•