Closed Bug 201576 Opened 21 years ago Closed 21 years ago

nsImageWin cleanup

Categories

(Core Graveyard :: GFX: Win32, defect)

Product:
Core Graveyard
Component:
GFX: Win32
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: smontagu, Assigned: smontagu)

References

Details

Attachments

(1 file, 2 obsolete files)

Addressed comments
16.62 KB, patch
smontagu
: review+
tor
: superreview+
Details | Diff | Splinter Review 
Separating out the "gratuitous style and whitespace changes" from bug 143046 to
make it more reviewable
Attached patch Patch (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        The same, diff -u9w (obsolete)
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #120144 -
        Flags: superreview?(tor)

        Attachment #120144 -
        Flags: review?(paper)

    
    

    
  
Comment on attachment 120144 [details] [diff] [review]
Patch

This looks good, other than that ++y ;)
But that isn't a reason to withhold a review.  If you remember, you could
change it to y++ before checkin in.  If not, it isn't essential for me.

        Attachment #120144 -
        Flags: review?(paper) → review+

    
    

    
  
Comment on attachment 120144 [details] [diff] [review]
Patch

With the removal of CleanUpDIBSection (which incidentally wasn't
removed from the header) it appears that you are leaking mAlphaBits.

    
  

        Attachment #120144 -
        Flags: superreview?(tor) → superreview-

    
    

    
  


  
Moved delete of mAlphaBits into the dtor, removed CleanUpDIBSection from the
header and changed ++y back to y++

    
  

        Attachment #120144 -
        Attachment is obsolete: true

        Attachment #120145 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 120477 [details] [diff] [review]
Addressed comments

Transferring r=paper and rerequesting sr.

        Attachment #120477 -
        Flags: superreview?(tor)

        Attachment #120477 -
        Flags: review+

    
  

        Attachment #120477 -
        Flags: superreview?(tor) → superreview+

    
    

    
  
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: