Closed
Bug 2015837
Opened 9 months ago
Closed 9 months ago
Use private fields in CssRuleView
Categories
(DevTools :: Inspector: Rules, task, P3)
DevTools
Inspector: Rules
Tracking
(firefox149 fixed)
RESOLVED
FIXED
149 Branch
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 2 open bugs)
Details
Attachments
(2 external files)
This class has a bunch of _ prefixed attributes used outside of the class.
So that using private properties would better highlight the scope of each internal attribute.
Updated•9 months ago
|
Blocks: 2011387
Summary: Use private files in CssRuleView → Use private fields in CssRuleView
Updated•9 months ago
|
Priority: -- → P3
| Assignee | ||
Comment 1•9 months ago
|
||
Updated•9 months ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•9 months ago
|
||
Pushed by apoirot@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8f762af1d81e
https://hg.mozilla.org/integration/autoland/rev/b4c112fbc18a
[devtools] Use abort controller for CSSRuleView. r=devtools-reviewers,nchevobbe
https://github.com/mozilla-firefox/firefox/commit/7fbd47ecb559
https://hg.mozilla.org/integration/autoland/rev/8f3ec749f33a
[devtools] Use private properties in CssRuleView. r=devtools-reviewers,nchevobbe
Comment 4•9 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b4c112fbc18a
https://hg.mozilla.org/mozilla-central/rev/8f3ec749f33a
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox149:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
Updated•8 months ago
|
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in
before you can comment on or make changes to this bug.
Description
•