2015877 - (wasm-jspi-nightly) Enable WebAssembly JS-PI in Nightly

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Ryan Hunt [:rhunt]]

Tracking bug for flipping on JS-PI in Nightly.

Comment 1

[Sebastian Zartner [:sebo]]

Once it's enabled, it should probably be added to https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features and be mentioned in the Nightly release notes.

Sebastian

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 2015877 - wasm: Strengthen features.js test. r?yury

• Extend getBuildConfiguration to report what's compiled in the binary.
• Ensure we're feature testing everything that's compiled in.
• Move to directiveless so we can assume no experimental flags were added
  by a jit-test directive.
• Normalize the relaxedSIMD name to simplify the test.

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 2015877 - wasm: Enable JS-PI in nightly. r?yury

Don't force enable stack-switching when we enable JS-PI, instead
only enable it for the builtin modules that JS-PI internally uses.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/41a6b4286dd1
https://hg.mozilla.org/integration/autoland/rev/41679109886e
wasm: Strengthen features.js test. r=yury
https://github.com/mozilla-firefox/firefox/commit/c8ec6bfcb8ec
https://hg.mozilla.org/integration/autoland/rev/e09e5889dcc1
wasm: Enable JS-PI in nightly. r=yury,webidl,dom-worker-reviewers,smaug,asuth

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/82e4b736deff
https://hg.mozilla.org/integration/autoland/rev/2a636a0ba55f
Revert "Bug 2015877 - wasm: Enable JS-PI in nightly. r=yury,webidl,dom-worker-reviewers,smaug,asuth" for causing mochitest failures at test_worker_interfaces.html

Comment 6

[rperta]

Backed out for causing mochitest failures at test_worker_interfaces.html
Backout link
Push with failures
Failure log(s)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e088592c0c48
https://hg.mozilla.org/integration/autoland/rev/52c9919cbbef
wasm: Strengthen features.js test. r=yury
https://github.com/mozilla-firefox/firefox/commit/1fc4b696baab
https://hg.mozilla.org/integration/autoland/rev/d04dd7575cde
wasm: Enable JS-PI in nightly. r=yury,webidl,dom-worker-reviewers,smaug,asuth

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/52c9919cbbef
https://hg.mozilla.org/mozilla-central/rev/d04dd7575cde

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This causes wasm crashes such as bp-2dc78c16-94c6-414c-a153-8d5f90260506. Code sheriffs will revert the changes to resolve the issue with the next Nightly.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c90c4a59e34b
https://hg.mozilla.org/mozilla-central/rev/249aec08cc0d
Revert "Bug 2015877 - wasm: Enable JS-PI in nightly. r=yury,webidl,dom-worker-reviewers,smaug,asuth" as requested by @aryx for causing wasm crashes.

Comment 11

[Serban Stanca [:SerbanS]]

Reverted this as requested by @aryx for causing wasm crashes.

• Revert link

Comment 12

[Ryan Hunt [:rhunt]]

Looks like that website was feature-detecting JS-PI and started running it in Nightly once it was enabled.

Their code ran into a bug in the wasm bytecode we internally emit, which was caught by our validator and turned into a crash. I have a fix to handle it. I verified that website no longer crashes.

Comment 13

[Ryan Hunt [:rhunt]]

Attachment: Bug 2015877 - wasm: Use varS32 for RefCast in JS-PI. r?yury

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a35a1db7d2b2
https://hg.mozilla.org/integration/autoland/rev/231be873b268
wasm: Strengthen features.js test. r=yury
https://github.com/mozilla-firefox/firefox/commit/7135e2a972cf
https://hg.mozilla.org/integration/autoland/rev/95cf8946e2e4
wasm: Enable JS-PI in nightly. r=yury,webidl,dom-worker-reviewers,smaug,asuth
https://github.com/mozilla-firefox/firefox/commit/dba13df13662
https://hg.mozilla.org/integration/autoland/rev/4805c9f7f6f0
wasm: Use varS32 for RefCast in JS-PI. r=yury

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/231be873b268
https://hg.mozilla.org/mozilla-central/rev/95cf8946e2e4
https://hg.mozilla.org/mozilla-central/rev/4805c9f7f6f0

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Is this something you wanted to call out in the Nightly release notes? Please add a relnote-firefox? nomination to the bug if yes.

Comment 17

[Ryan Hunt [:rhunt]]

Yes this is worth calling out in Nightly release notes (didn't know we had had Nightly only release notes). I was planning on the main release notes when we let it ride the trains (either this release or next).

Release Note Request (optional, but appreciated)
[Why is this notable]: New WebAssembly feature the helps porting applications to the Web.
[Affects Firefox for Android]: Yes
[Suggested wording]: Enabled the WebAssembly JS-Promise-Integration proposal in Nightly.
[Links (documentation, blog post, etc)]: https://github.com/WebAssembly/js-promise-integration/blob/main/proposals/js-promise-integration/Overview.md

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx152 nightly release notes, please allow 30 minutes for the site to update.
The nightly-only note will be removed after three cycles or when it is enabled by default, whichever comes earlier.

Comment 19

[Chris Mills [:cmills]]

Docs for 152: We've just added a release note for now.

We are documenting the feature properly for 153, with docs work being tracked in https://github.com/mdn/content/issues/44468 / https://bugzilla.mozilla.org/show_bug.cgi?id=2044809