201588 - After migrating 4.x profiles the addrbooks are not sorted correctly.

Status: RESOLVED FIXED

(MailNews Core :: Profile Migration, defect)

Description

[Cavin Song]

Migrate a 4.x profile with cards in Personal Address Book and also in other
address book other than Personal Address Book and Collected Addresses like
'Business', 'Firends' etc. After migration is done, opne the addrbook window and
the order is like:

Collected Addresses
Business
Personal Address Book

The order should have been:

Personal Address Book
Collected Addresses
Business

Comment 1

[Cavin Song]

There are two problems in the code here:

1. In nsAbBSDirectory::CreateDirectoryByURI() we forgot to set property dirType
before calling CreateDirectoriesFromFactory().
2. In DIR_AddNewAddressBook(), when doing migration we need to set 'prefName' so
the caller will be ablt to get the correct directory properties.

Failing to do any of the above will make the addrbooks as type 'LDAPDirectory'.

Comment 2

[Cavin Song]

Attachment: Proposed patch, v1

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 120246 [details] [diff] [review]
Proposed patch, v1

sr=sspitzer, but change:

"will be ablt"
to
"will be able"

Comment 4

[shliang]

Comment on attachment 120246 [details] [diff] [review]
Proposed patch, v1

r=shuehan

Comment 5

[Cavin Song]

Fix checked in.

Comment 6

[Cavin Song]

Forgot to mark it FIXED.