Closed Bug 201588 Opened 17 years ago Closed 17 years ago

After migrating 4.x profiles the addrbooks are not sorted correctly.

Categories

(MailNews Core :: Profile Migration, defect)

x86
Windows 2000
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cavin, Assigned: cavin)

Details

Attachments

(1 file)

Migrate a 4.x profile with cards in Personal Address Book and also in other
address book other than Personal Address Book and Collected Addresses like
'Business', 'Firends' etc. After migration is done, opne the addrbook window and
the order is like:

Collected Addresses
Business
Personal Address Book

The order should have been:

Personal Address Book
Collected Addresses
Business
There are two problems in the code here:

1. In nsAbBSDirectory::CreateDirectoryByURI() we forgot to set property dirType
before calling CreateDirectoriesFromFactory().
2. In DIR_AddNewAddressBook(), when doing migration we need to set 'prefName' so
the caller will be ablt to get the correct directory properties.

Failing to do any of the above will make the addrbooks as type 'LDAPDirectory'.
Summary: 1. After migrating 4.x profiles the addrbooks are not sorted correctly. → After migrating 4.x profiles the addrbooks are not sorted correctly.
Attachment #120246 - Flags: superreview?(sspitzer)
Comment on attachment 120246 [details] [diff] [review]
Proposed patch, v1

sr=sspitzer, but change:

"will be ablt"
to
"will be able"
Attachment #120246 - Flags: superreview?(sspitzer) → superreview+
Comment on attachment 120246 [details] [diff] [review]
Proposed patch, v1

r=shuehan
Attachment #120246 - Flags: review+
Fix checked in.
QA Contact: esther → nbaca
Forgot to mark it FIXED.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.