2016030 - prodamus.ru - Document is not fully visible

Status: ASSIGNED

(Web Compatibility :: Site Reports, defect, P3)

Description

[Calin Tanase]

Environment:
Operating system: Android 15/Windows 10
Firefox version: Firefox Mobile [phone]

Steps to reproduce:

1. Go to https://prodamus.ru/pravila-provedeniya-akcii-fevral-vozmozhnostej
   2.Observe the page.

Expected Behavior:
The document is fully visible.

Actual Behavior:
Document is not fully visible.

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in firefox-nightly, and firefox-release
• Does not reproduce in chrome

Created from https://github.com/webcompat/web-bugs/issues/205933

Comment 1

[Calin Tanase]

Attachment: image.png

Comment 2

[Sky Schubert [:skyschub]]

That's just an iFrame, and it's not full-height.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Standalone test case

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Reduced test case

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Daniel, can you finish up the diagnosis using the reduced test case?

Comment 6

[Daniel Holbert [:dholbert]]

Will do. bmoattachments.org is having trouble right now so I can't view the reduced testcase, but once that's back up, I can take a look.

Comment 7

[Daniel Holbert [:dholbert]]

Based on the reduced testcase, this is bug 1598458.

On the specific page linked in comment 0, we could work around this by adding this CSS (possible sitepatch):

.t396 .tn-atom { height: 100% }

The intent would be to extend this rule that makes that element an auto-height table cell:

.t396 .tn-atom {
	display: table-cell;
	vertical-align: middle;
	width: 100%;
	-webkit-text-size-adjust: 100%;
	-moz-text-size-adjust: 100%;
	-ms-text-size-adjust: 100%;
}

...from this stylesheet:
https://static.tildacdn.com/ws/project5499568/tilda-blocks-page116435696.min.css?t=1770301426

But that's only useful for cases where the table-cell has a percent-height child (as in the linked page). It's possible that this site has similar styles on other pages without a percent-height child, and the sitepatch could break the layout on those pages.

Comment 8

[Thomas Wisniewski [:twisniewski][on PTO until July 6]]

I found that adding this CSS for the iframe for the PDF works fine too, Dan:

iframe[src*="pdf"] {
  height:100vh;
}

I think that's a safer work-around, do you agree?

Comment 9

[Daniel Holbert [:dholbert]]

Sure -- but maybe best to add a tn-atom descendant-selector in there as well, to make it more specific, like so:

.tn-atom iframe[src*="pdf"] {
  height:100vh;
}

Thanks!

Comment 10

[Daniel Holbert [:dholbert]]

(I tested the comment 9 CSS-snippet in stylus and confirmed it fixes the site for me, BTW.)

Comment 11

[Thomas Wisniewski [:twisniewski][on PTO until July 6]]

Attachment: Bug 2016030 - add a CSS webcompat intervention for prodamus.ru; r?ksenia

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9c44704879d6
https://hg.mozilla.org/integration/autoland/rev/ec294485b0f0
add a CSS webcompat intervention for prodamus.ru; r=ksenia,webcompat-reviewers

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ec294485b0f0