201609 - Cancelling publish doesn't really cancel currently executing uploads

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[jag (Peter Annema)]

In testing for another bug I found that calling cancel while we're publising a
document doesn't really cancel it, the upload keeps going till it's done or
Mozilla gets closed (whichever happens first). There seem to be two problems.
One is that in the JS for the dialog we don't have access to the
webbrowserpersist object to call cancel on it, the other is that with that fixed
(patch coming up) the backend still doesn't cancel any channels open for this
(these) upload(s).

Comment 1

[jag (Peter Annema)]

Attachment: Init gPersistObj so we can call cancelSave on it when cancel is pressed

Comment 2

[jag (Peter Annema)]

See bug 201610 for the backend problem.

Comment 3

[jag (Peter Annema)]

Attachment: Alternate approach, return the persist obj from StartPublishing

Comment 4

[Sean Su]

Comment on attachment 120175 [details] [diff] [review]
Alternate approach, return the persist obj from StartPublishing

r=ssu

Comment 5

[Kathleen :Brade]

moa=brade

Comment 6

[jag (Peter Annema)]

Checked the patch in, waiting for bug 201610 to be fixed.

Comment 7

[Samir Gehani]

Editor triage team: nsbeta1+/adt2

Marking fixed since jag fixed the front-end issue and has filed 201610 for the
back-end issue.

Comment 8

[Chris Petersen]

I'm not sure how to verify this one since bug 201610 hasn't been resolved yet.

Comment 9

[Chris Petersen]

From my testing with the 2003-05-23-09 Win32 and 2003-05-23-07 Macho trunk
builds,  I was able to successfully cancel the ftp publishing process in Composer.