2016125 - Add a repeating quad shader

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

We want a specific shader for repeating small patterns over potentially large areas (as opposed to supporting repetitions in all other pattern shaders).

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 2016125 - Add a repeating quad shader. r=gw

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 2016125 - Extract the code to render the indirect pattern into its own function. r=gw

The repeating pattern code path will use it.

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 2016125 - Reenable the quads path when there are repetitions. r=gw

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 2016125 - Introduce a pattern offset for manually repeated patterns. r=gw

Now that pattern coordinates are in the same coordinate space as the primitive, we need some way to inform that the primitive
is offset when emitting tile repetitions on the CPU.

I am not very happy about this solution. The prepare_* functions in quad.rs have too many arguments already.
This is made somewhat worse by having to pass the extra offset everywhere we pass the pattern builder, so it may not be a big issue if we find a way to remove the shared pattern logic and just build the pattern early.
Another potential solution is to stop using the primitive template as the pattern builder and have it create something that implements pattern builder, so that that thing can maybe more easily be offset.

For now I propose that we stick with this less ideal solution and revisit towards the end of the project. By then the code will have changed enough that the best long-term solution will probably be easier to see.

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 2016125 - Prevent clipped out segments from being emitted. r=gw

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 2016125 - Add a SWGL fast path for repeated patterns without spacing. r=gw

Comment 7

[Nicolas Silva [:nical]]

Attachment: Bug 2016125 - Disable caching for manually repeated quads. r=gw

Caching causes issues with SWGL specifically. Something to worry about later.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7542018bbacd
https://hg.mozilla.org/integration/autoland/rev/3aa0f986682f
Extract the code to render the indirect pattern into its own function. r=gw
https://github.com/mozilla-firefox/firefox/commit/6a523786368c
https://hg.mozilla.org/integration/autoland/rev/e8bfcfbb690d
Add a repeating quad shader. r=gw
https://github.com/mozilla-firefox/firefox/commit/6f8a450a342f
https://hg.mozilla.org/integration/autoland/rev/7c7f68e16f99
Reenable the quads path when there are repetitions. r=gw
https://github.com/mozilla-firefox/firefox/commit/5e55555e23d8
https://hg.mozilla.org/integration/autoland/rev/fdfad589171f
Introduce a pattern offset for manually repeated patterns. r=gw
https://github.com/mozilla-firefox/firefox/commit/73b4d6146107
https://hg.mozilla.org/integration/autoland/rev/9c37fc89ce06
Prevent clipped out segments from being emitted. r=gw
https://github.com/mozilla-firefox/firefox/commit/f19b64bd94ab
https://hg.mozilla.org/integration/autoland/rev/3f582f27986f
Add a SWGL fast path for repeated patterns without spacing. r=gw
https://github.com/mozilla-firefox/firefox/commit/49e28ee57ec6
https://hg.mozilla.org/integration/autoland/rev/1ae6b5314a8c
Disable caching for manually repeated quads. r=gw

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3aa0f986682f
https://hg.mozilla.org/mozilla-central/rev/e8bfcfbb690d
https://hg.mozilla.org/mozilla-central/rev/7c7f68e16f99
https://hg.mozilla.org/mozilla-central/rev/fdfad589171f
https://hg.mozilla.org/mozilla-central/rev/9c37fc89ce06
https://hg.mozilla.org/mozilla-central/rev/3f582f27986f
https://hg.mozilla.org/mozilla-central/rev/1ae6b5314a8c