2016126 - Allow top level loads to restart rows

Status: RESOLVED FIXED

(DevTools :: Application Panel, task, P2)

Description

[Andreas Farre [:farre]]

When navigating between sites that have lots of iframes we'll get lots of rows, e.g if we navigation from cnn.com to bbc.co.uk. Currently we solve this by just ending cnn.com's rows and letting bbc.co.uk's contiunue below. Instead we could have a separator between the last column of cnn.com and the first of bbc.co.uk to indicate the cells are no longer related across rows.
Instead of:

  // +------------------+------------------+------------------+
  // |        0         |        1         |        2         |
  // +------------------+------------------+------------------+
  // | cnn.com          |                  |                  |
  // +------------------+------------------+------------------+
  // | iframe.html      | iframe.html?1    |                  |
  // +------------------+------------------+------------------+
  // |                                     | bbc.co.ukml      |
  // +------------------+------------------+------------------+
  // |                                     | iframe.html      |
  // +------------------+------------------+------------------+

do:

  // +------------------+------------------++------------------+
  // |        0         |        1         ||        2         |
  // +------------------+------------------++------------------+
  // | cnn.com          |                  || bbc.co.uk        |
  // +------------------+------------------++------------------+
  // | iframe.html      | iframe.html?1    || iframe.html      |
  // +------------------+------------------++------------------+

Comment 1

[Andreas Farre [:farre]]

Attachment: image.png

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 2016126 - More clearly distinguish top level cross document navigations. r=#devtools-reviewers!

Switch from creating a list of rows into creating a list of diagrams
where every diagram's top-level entries are same-document. These
diagrams in turn contain the list of rows for that particular diagram.
These can then in turn be visualized in a way that saves on vertical
UI real estate.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8fe63b0f8d49
https://hg.mozilla.org/integration/autoland/rev/4096fe84f768
More clearly distinguish top level cross document navigations. r=devtools-reviewers,nchevobbe

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4096fe84f768