Closed Bug 2016133 Opened 9 months ago Closed 7 months ago

Allow users to choose a Default search engine for Standard and Private Mode

Categories

(Firefox for Android :: Search, enhancement)

Product:
Firefox for Android
Component:
Search
Platform:
All
Android
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
151 Branch
Tracking Flags:
Tracking Status
firefox151 --- verified

People

(Reporter: jbillman, Assigned: harrisono)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group3] )

User Story

I want to search with Google when I'm in standard mode, but when I switch over to Private Mode I always want to be using DuckDuckGo

Attachments

(5 external files)

Steps to reproduce

  1. Settings
  2. General
  3. Search
  4. Default search engine (all or nothing, unable to set by mode)

Expected behavior

Under General > Search > Default search engine, have a section for Standard mode and another for Private Mode

Actual behavior

Device information

  • Firefox version:
  • Android device model:
  • Android OS version:

Any additional information?

See Also: → private-search
Assignee: nobody → hoglesby
Status: NEW → ASSIGNED
Flags: qe-verify+
Blocks: 2028574
Pushed by hoglesby@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/55b9a075a4b0 https://hg.mozilla.org/integration/autoland/rev/5d4d38323661 Part 1: Add state and middleware layer for separate private browsing default search engine r=android-reviewers,petru https://github.com/mozilla-firefox/firefox/commit/2c005a859903 https://hg.mozilla.org/integration/autoland/rev/83b78fdb0683 Part 2: Update SearchUseCases to include private browsing default search engine r=android-reviewers,petru https://github.com/mozilla-firefox/firefox/commit/34735e2e66ba https://hg.mozilla.org/integration/autoland/rev/234473b146f1 Part 3: Update Search Engine settings screen for private browsing default search engine r=android-reviewers,android-l10n-reviewers,flod,petru https://github.com/mozilla-firefox/firefox/commit/5b3b44579734 https://hg.mozilla.org/integration/autoland/rev/1fe932df9883 Part 4: Update all search engine entry points for private browsing default search engine changes r=android-reviewers,petru https://github.com/mozilla-firefox/firefox/commit/326926b66324 https://hg.mozilla.org/integration/autoland/rev/6a7ec3fb09cb Part 5: Add telemetry for new private browsing default search engine pick r=android-reviewers,petru
Regressions: 2029152
Regressions: 2030013

Verified as implemented on the Firefox for Android Nightly 151.0a1 from 4/6 with the following devices:

  • Pixel 6 (Android 17),
  • Lenovo TB X606X (Android 10),
  • Samsung Galaxy Note 8 (Android 9), and
  • Oppo Find N2 Flip (Android 15).
status-firefox151: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: