`moz-phab uplift` should strip `DONTBUILD` from commit message
Categories
(Conduit :: moz-phab, defect, P3)
Tracking
(Not tracked)
People
(Reporter: sheehan, Assigned: sheehan)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
See https://phabricator.services.mozilla.com/D282791 as an example.
The original patch landed with the DONTBUILD flag set in the commit message. This was then added to the uplift revision, which would then cause the flag to be added to the landing to the uplift train.
moz-phab uplift should strip DONTBUILD from the commit message before creating the revision in Phabricator.
We could also have Lando remove DONTBUILD from the commit message before landing, but doing this at the moz-phab level means the flag won't appear in the revision on Phabricator and cause confusion.
|
Assignee | |
Updated•6 months ago
|
|
|
Assignee | |
Comment 1•6 months ago
|
||
Strip DONTBUILD flag from the commit message title during
moz-phab uplift, as landing on the uplift train may require
a build, unlike the original landing.
|
||
Updated•6 months ago
|
|
||
Comment 2•6 months ago
|
||
Authored by https://github.com/cgsheeh
https://github.com/mozilla-conduit/review/commit/827f754dba735ba70c21fda7d42e3600c829f25b
[main] uplift: strip DONTBUILD flag from title (Bug 2016153) r=zeid
Description
•