Open Bug 2016160 Opened 9 months ago Updated 1 month ago

Refactor dismissSelectPrompts in PromptFeature.kt to remove suppressions

Categories

(Firefox for Android :: Tooling, task)

All
Android
task

Tracking

()

People

(Reporter: Gela, Assigned: apurva.agrawal3003, Mentored)

Details

(Keywords: good-first-bug)

Refactor dismissSelectPrompts() in android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/PromptFeature.kt to remove the following suppressions:

@Suppress("ForbiddenSuppress", "CyclomaticComplexMethod", "CognitiveComplexMethod")

Keywords: good-first-bug

Could this be assigned to me? I'd like to work on it.

Mentor: gmalekpour
Assignee: nobody → apurva.agrawal3003

(In reply to Apurva from comment #1)

Could this be assigned to me? I'd like to work on it.

Sure, I've assigned this to you

Looking at current central, dismissSelectPrompts() only carries @VisibleForTesting, The @Suppress("ForbiddenSuppress", "CyclomaticComplexMethod", "CognitiveComplexMethod") annotation isn't there, and git log -S doesn't show it ever being removed. ./mach gradle :components:feature-prompts:detekt passes as-is.

There are still four ForbiddenSuppress entries for PromptFeature.kt in config/detekt-baseline.xml (lines 116-119), covering start(), processPromptRequest(), onConfirm(), and handleDialogsRequest(). Would you like me to retarget this bug at one of those instead?

Looking at current central, dismissSelectPrompts() only carries @VisibleForTesting, The @Suppress("ForbiddenSuppress", "CyclomaticComplexMethod", "CognitiveComplexMethod") annotation isn't there, and git log -S doesn't show it ever being removed. ./mach gradle :components:feature-prompts:detekt passes as-is.
There are still four ForbiddenSuppress entries for PromptFeature.kt in config/detekt-baseline.xml (lines 116-119), covering start(), processPromptRequest(), onConfirm(), and handleDialogsRequest(). Would you like me to retarget this bug at one of those instead?

Was this comment written by AI?... 😕 But sure. Go for it.

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Tooling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Tooling
You need to log in before you can comment on or make changes to this bug.