Closed
Bug 2016190
Opened 8 months ago
Closed 4 months ago
setCodecPreferences cannot disable red/rtx
Categories
(Core :: WebRTC: Signaling, defect, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We do not seem to disable rtx based on prefs here, and this is causing a test-case in webrtc/RTCRtpTransceiver-setCodecPreferences.html to fail.
https://searchfox.org/firefox-main/source/dom/media/webrtc/jsep/JsepCodecDescription.h#643,650
|
Assignee | |
Comment 1•7 months ago
|
||
|
|
Assignee | |
Comment 2•4 months ago
|
||
I think I've accidentally fixed this while getting test code working for bug 2044894.
Assignee: nobody → docfaraday
|
|
Assignee | |
Comment 3•4 months ago
|
||
Pushed by bcampen@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/381dc2fa7e46
https://hg.mozilla.org/integration/autoland/rev/2268a40afe75
Pay attention to config for rtx/red. r=dbaker
https://github.com/mozilla-firefox/firefox/commit/3287330cd5dd
https://hg.mozilla.org/integration/autoland/rev/318bf8fcb99c
2044894: apply code formatting via Lando
|
||
Comment 5•4 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2268a40afe75
https://hg.mozilla.org/mozilla-central/rev/318bf8fcb99c
Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
|
||
Updated•3 months ago
|
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in
before you can comment on or make changes to this bug.
Description
•