Closed Bug 2016506 Opened 9 months ago Closed 8 months ago

Assertion failure: mFrames.IsEmpty() (unexpected second call to SetInitialChildList), at /builds/worker/checkouts/gecko/layout/generic/nsContainerFrame.cpp:75

Categories

(Core :: Layout, defect)

defect

Tracking

()

VERIFIED FIXED
150 Branch
Tracking Status
firefox-esr140 --- unaffected
firefox148 --- fixed
firefox149 --- verified
firefox150 --- verified

People

(Reporter: tsmith, Assigned: emilio)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: assertion, regression, testcase, Whiteboard: [bugmon:bisected,confirmed], [wptsync upstream])

Attachments

(1 file, 3 external files, 1 obsolete file)

Attached file testcase.html —

Found while fuzzing m-c 20260210-80200c065fb1 (--enable-debug --enable-fuzzing)

To reproduce via Grizzly Replay:

$ pip install fuzzfetch grizzly-framework --upgrade
$ python -m fuzzfetch -d --fuzzing -n firefox
$ python -m grizzly.replay.bugzilla ./firefox/firefox <bugid>

Assertion failure: mFrames.IsEmpty() (unexpected second call to SetInitialChildList), at /builds/worker/checkouts/gecko/layout/generic/nsContainerFrame.cpp:75

#0 0x7d65e6dd88c5 in MOZ_CrashSequence /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:237:3
#1 0x7d65e6dd88c5 in nsContainerFrame::SetInitialChildList(mozilla::FrameChildListID, nsFrameList&&) /builds/worker/checkouts/gecko/layout/generic/nsContainerFrame.cpp:74:5
#2 0x7d65e6cd14f7 in nsCSSFrameConstructor::ConstructFrameFromItemInternal(nsCSSFrameConstructor::FrameConstructionItem&, nsFrameConstructorState&, nsContainerFrame*, nsFrameList&) /builds/worker/checkouts/gecko/layout/base/nsCSSFrameConstructor.cpp:3865:28
#3 0x7d65e6cd4cdf in nsCSSFrameConstructor::ConstructFramesFromItem(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList::Iterator&, nsContainerFrame*, nsFrameList&) /builds/worker/checkouts/gecko/layout/base/nsCSSFrameConstructor.cpp:5360:3
#4 0x7d65e6cc6aa5 in nsCSSFrameConstructor::ConstructFramesFromItemList(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList&, nsContainerFrame*, bool, nsFrameList&) /builds/worker/checkouts/gecko/layout/base/nsCSSFrameConstructor.cpp:8948:5
#5 0x7d65e6cd8800 in nsCSSFrameConstructor::ContentRangeInserted(nsIContent*, nsIContent*, nsCSSFrameConstructor::InsertionKind) /builds/worker/checkouts/gecko/layout/base/nsCSSFrameConstructor.cpp:6535:3
#6 0x7d65e6bcc804 in mozilla::RestyleManager::ProcessRestyledFrames(nsStyleChangeList&) /builds/worker/checkouts/gecko/layout/style/RestyleManager.cpp:1672:25
#7 0x7d65e6bd3ccd in mozilla::RestyleManager::DoProcessPendingRestyles(mozilla::ServoTraversalFlags) /builds/worker/checkouts/gecko/layout/style/RestyleManager.cpp:3195:7
#8 0x7d65e6bd4f61 in mozilla::RestyleManager::ProcessPendingRestyles() /builds/worker/checkouts/gecko/layout/style/RestyleManager.cpp:3294:3
#9 0x7d65e6c7fc4a in mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) /builds/worker/checkouts/gecko/layout/base/PresShell.cpp:4487:37
#10 0x7d65e2bbbb2d in FlushPendingNotifications /builds/worker/workspace/obj-build/dist/include/mozilla/PresShell.h:1535:5
#11 0x7d65e2bbbb2d in mozilla::dom::Document::DetermineProximityToViewportAndNotifyResizeObservers() /builds/worker/checkouts/gecko/dom/base/Document.cpp:18978:11
#12 0x7d65e6c41874 in operator() /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:2511:14
#13 0x7d65e6c41874 in operator() /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:1313:7
#14 0x7d65e6c41874 in RunRenderingPhaseLegacy<(lambda at /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:1292:35)> /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:1285:3
#15 0x7d65e6c41874 in void nsRefreshDriver::RunRenderingPhase<nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsRefreshDriver::IsExtraTick)::$_11>(mozilla::RenderingPhase, nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsRefreshDriver::IsExtraTick)::$_11&&, bool (*)(mozilla::dom::Document const&)) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:1292:3
#16 0x7d65e6c3d4bc in nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsRefreshDriver::IsExtraTick) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:2507:3
#17 0x7d65e6c47081 in TickDriver /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:366:13
#18 0x7d65e6c47081 in mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver>>&) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:344:7
#19 0x7d65e6c46f80 in mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:360:5
#20 0x7d65e6c46e2d in mozilla::VsyncRefreshDriverTimer::RunRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:950:5
#21 0x7d65e6c463ca in mozilla::VsyncRefreshDriverTimer::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:860:5
#22 0x7d65e6c458b6 in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsyncTimerOnMainThread() /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:591:14
#23 0x7d65e5ffa48b in mozilla::dom::VsyncMainChild::RecvNotify(mozilla::VsyncEvent const&, float const&) /builds/worker/checkouts/gecko/dom/ipc/VsyncMainChild.cpp:66:15
#24 0x7d65e6271819 in mozilla::dom::PVsyncChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PVsyncChild.cpp:229:78
#25 0x7d65e17a95a2 in mozilla::ipc::PBackgroundChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PBackgroundChild.cpp:5103:32
#26 0x7d65e174962e in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1801:25
#27 0x7d65e1746bb0 in mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, std::unique_ptr<IPC::Message, std::default_delete<IPC::Message>>) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1727:9
#28 0x7d65e17475b7 in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1516:3
#29 0x7d65e1748599 in mozilla::ipc::MessageChannel::MessageTask::Run() /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1618:14
#30 0x7d65e0b3d627 in mozilla::RunnableTask::Run() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:721:16
#31 0x7d65e0b37cf4 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:1342:20
#32 0x7d65e0b36977 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:1165:15
#33 0x7d65e0b36df5 in mozilla::TaskController::ProcessPendingMTTask(bool) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:657:36
#34 0x7d65e0b46906 in operator() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:349:37
#35 0x7d65e0b46906 in mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_0>::Run() /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.h:549:5
#36 0x7d65e0b58e83 in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1168:16
#37 0x7d65e0b5eadf in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:461:10
#38 0x7d65e174ee67 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:85:21
#39 0x7d65e16a7bb1 in RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:366:3
#40 0x7d65e16a7bb1 in MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:348:3
#41 0x7d65e68455e8 in nsBaseAppShell::Run() /builds/worker/checkouts/gecko/widget/nsBaseAppShell.cpp:152:27
#42 0x7d65e6910d34 in nsAppShell::Run() /builds/worker/checkouts/gecko/widget/gtk/nsAppShell.cpp:555:33
#43 0x7d65e79589fb in XRE_RunAppShell() /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:652:20
#44 0x7d65e174fd14 in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:235:9
#45 0x7d65e16a7bb1 in RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:366:3
#46 0x7d65e16a7bb1 in MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:348:3
#47 0x7d65e795815f in XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:590:34
#48 0x5c2fb88a9f7c in main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:465:22
Flags: in-testsuite?

Verified bug as reproducible on mozilla-central 20260212213836-06d48ece4edf.
The bug appears to have been introduced in the following build range:

Start: 5e2e0937d2b175d4c3d9c5f611f85c4ff957bc6b (20260210102756)
End: 012ebfd1eec96870acc52d551ca0adadd12f3e9b (20260210111333)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5e2e0937d2b175d4c3d9c5f611f85c4ff957bc6b&tochange=012ebfd1eec96870acc52d551ca0adadd12f3e9b

Keywords: regression
Whiteboard: [bugmon:bisected,confirmed]

:nikal do you suspect that https://bugzilla.mozilla.org/show_bug.cgi?id=1998432 could have caused this?

(In reply to Lesley Norton [:lnorton] from comment #2)

:nikal do you suspect that https://bugzilla.mozilla.org/show_bug.cgi?id=1998432 could have caused this?

Did you forget to send an "NEED INFO" request to :nikal?

cc :nical at least

However, all patches of Bug 1998432 is related to web-render, so it may not be related to the assertion of empty frames.
Bug 2015488 also touched some of the frame constructor code, so I cc Emilio as well.

Yeah the test-case has fullscreen and such, so bug 2015488 seems the most likely candidate.

Keywords: pernosco
Regressed by: 2015488

If you make a fullscreen <frameset>, it goes out of flow and now we
create a backdrop.

Framesets are super weird, they create child frames on Init()... They
are also supposed to not be out of flow, but fullscreen trumps that.

This keeps effectively the pre-regression state of affairs.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Keywords: pernosco
Pushed by ealvarez@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6af9d4cbfc58 https://hg.mozilla.org/integration/autoland/rev/113a16c6592a Deal with non-empty lists in nsHTMLFramesetFrame::SetInitialChildList. r=layout-reviewers,dshin
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57988 for changes under testing/web-platform/tests
Whiteboard: [bugmon:bisected,confirmed] → [bugmon:bisected,confirmed], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot

Verified bug as fixed on rev mozilla-central 20260224034324-02dd9f8b7312.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Status: RESOLVED → VERIFIED
Keywords: bugmon

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(emilio)

This prevents ::backdrop on framesets which is a poorly tested
code-path. Bug 2019341 is also fixed by this.

Attachment #9548565 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: Crashes
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: very targeted fix
  • String changes made/needed: none
  • Is Android affected?: yes

firefox-release Uplift Approval Request

  • User impact if declined: Crashes (see this and bug 2019341)
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: comment 0 or bug 2019341
  • Risk associated with taking this patch: low
  • Explanation of risk level: very targeted fix.
  • String changes made/needed: none
  • Is Android affected?: yes
Attachment #9548567 - Flags: approval-mozilla-release?
Flags: qe-verify+
Attachment #9548566 - Attachment is obsolete: true
Flags: needinfo?(emilio)
Attachment #9548565 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [uplift][qa-ver-needed-c150/b149]

Set release status flags based on info from the regressing bug 2015488

Hello! I can confirm that the issue is fixed with firefox 149.0b3 on Ubuntu 22.04, Windows 10 and MacOS 15.

I will update the flags and the status of this issue.

Have a nice day!

QA Whiteboard: [uplift][qa-ver-needed-c150/b149] → [qa-ver-done-c150/b149]
Flags: qe-verify+
Attachment #9548567 - Flags: approval-mozilla-release? → approval-mozilla-release+
Blocks: 2019341
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: