2016513 - Invalid debugger assertion around observability in light of multiple debuggers.

Status: ASSIGNED

(Core :: JavaScript Engine, task)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

  // Iterate through the scripts again and finish discarding
  // BaselineScripts. This must be done as a separate phase as we can only
  // discard the BaselineScript on scripts that have no IonScript.
  for (size_t i = 0; i < scripts.length(); i++) {
    MOZ_ASSERT_IF(scripts[i]->isDebuggee(), observing);
    if (!scripts[i]->jitScript()->icScript()->active()) {
      FinishDiscardBaselineScript(gcx, scripts[i]);
    }
    scripts[i]->jitScript()->icScript()->resetActive();
  }

This assertion is not valid in light of the potential for multiple debuggers; patch and test case incoming.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 2016513 - Remove invalid debugger assertion around observability in light of multiple debuggers. r?arai

As the test case shows, we can get into a situation where a script is still a
debuggee, but we've got a mismatch on the observing flag because we've got more
than one debugger involved.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b05aa16b1006
https://hg.mozilla.org/integration/autoland/rev/97855d52230c
Remove invalid debugger assertion around observability in light of multiple debuggers. r=arai

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/27ef321a916b
https://hg.mozilla.org/integration/autoland/rev/83e917a390f3
Revert "Bug 2016513 - Remove invalid debugger assertion around observability in light of multiple debuggers. r=arai" for causing sm failures @ Debugger-collectCoverageInfo-observing-mismatch.js

Comment 4

[amarc]

Backed out for causing sm failures

• Backout link
• Push with failures
• Failure Log