2016666 - Always serialize the source table even when the JS sources feature is not enabled

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Nazım Can Altınova [:canova]]

Currently the source table is serialized only when the "JS Sources" feature is enabled. This is because we didn't need the source table before other than to see the JS sources themselves.

But I would like to add sourceMapURL to the source table which will allow us to:

1. Find the real function and file names (similar to the "symbolication" process)
2. Show the source mapped / prettified JS source in the source view.

"JS Sources" feature is necessary for the second task, but it's not necessary for the first one. We should still be able to see the source mapped function names even if the JS source is not present. That's why we should always serialize the source table.

This will also allow us to show better error messages in the frontend source view. See the discussion here.

Comment 1

[Nazım Can Altınova [:canova]]

Attachment: Bug 2016666 - Always serialize the source table even when the JS sources feature is not set r?mstange,dcarver

Comment 2

[Nazım Can Altınova [:canova]]

Attachment: Bug 2016666 - Add a test to make sure that source table is always serialized r?mstange,dcarver

Comment 3

[Nazım Can Altınova [:canova]]

Frontend PR: https://github.com/firefox-devtools/profiler/pull/5842

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/009aabfee2ff
https://hg.mozilla.org/integration/autoland/rev/848bbf7e1329
Always serialize the source table even when the JS sources feature is not set r=dcarver,profiler-reviewers
https://github.com/mozilla-firefox/firefox/commit/32d60c13222c
https://hg.mozilla.org/integration/autoland/rev/332d10898cc7
Add a test to make sure that source table is always serialized r=dcarver,profiler-reviewers

Comment 5

[Nazım Can Altınova [:canova]]

Attachment: Bug 2016666 - Fix the typo in the test

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2ccfea443938
https://hg.mozilla.org/integration/autoland/rev/9d2ddd52b431
Fix the typo in the test

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/848bbf7e1329
https://hg.mozilla.org/mozilla-central/rev/332d10898cc7
https://hg.mozilla.org/mozilla-central/rev/9d2ddd52b431

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/848bbf7e1329
https://hg.mozilla.org/mozilla-central/rev/332d10898cc7
https://hg.mozilla.org/mozilla-central/rev/9d2ddd52b431