2016673 - [bidi] Don't serialize UA widgets.

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2016673 - [bidi] Don't serialize UA widgets. r=whimboo!

In bug 2016280, I'm replacing the <input> element's internal nodes with
an internal shadow tree (a UA widget in the Gecko parlance).

That causes failures like this in
remote/webdriver-bidi/test/browser/browser_RemoteValueDOM.js:

TEST-UNEXPECTED-FAIL | remote/webdriver-bidi/test/browser/browser_RemoteValueDOM.js | test_serializeShadowRoot - Uncaught exception in test - TypeError: can't access property "has", seenNodeIds is undefined
getOrCreateNodeReference@chrome://remote/content/shared/webdriver/NodeCache.sys.mjs:91:11
getSharedIdForNode@chrome://remote/content/webdriver-bidi/RemoteValue.sys.mjs:469:20
serialize@chrome://remote/content/webdriver-bidi/RemoteValue.sys.mjs:881:40
serializeNode@chrome://remote/content/webdriver-bidi/RemoteValue.sys.mjs:726:31
serialize@chrome://remote/content/webdriver-bidi/RemoteValue.sys.mjs:889:26
serializeNode@chrome://remote/content/webdriver-bidi/RemoteValue.sys.mjs:703:9
serialize@chrome://remote/content/webdriver-bidi/RemoteValue.sys.mjs:889:26
serializeNode@chrome://remote/content/webdriver-bidi/RemoteValue.sys.mjs:726:31
serialize@chrome://remote/content/webdriver-bidi/RemoteValue.sys.mjs:889:26
@chrome://mochitests/content/browser/remote/webdriver-bidi/test/browser/browser_RemoteValueDOM.js line 849 > eval:152:42
@chrome://mochitests/content/browser/remote/webdriver-bidi/test/browser/browser_RemoteValueDOM.js line 849 > eval:164:5
@chrome://mochitests/content/browser/remote/webdriver-bidi/test/browser/browser_RemoteValueDOM.js:849:7
execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
_spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1624:15
receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:256:21
JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1415:14
JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1551:17
runTestInContent@chrome://mochitests/content/browser/remote/webdriver-bidi/test/browser/browser_RemoteValueDOM.js:771:24
test_serializeShadowRoot@chrome://mochitests/content/browser/remote/webdriver-bidi/test/browser/browser_RemoteValueDOM.js:580:9
handleTask@chrome://mochikit/content/browser-test.js:1302:26
_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1392:18
async*Tester_execTest@chrome://mochikit/content/browser-test.js:1539:14
nextTest/<@chrome://mochikit/content/browser-test.js:1282:14
SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1063:13
Leaving test test_serializeShadowRoot
Entering test test_serializeNodeSharedId

This is a pre-existing issue (e.g. you can trivially see that now if you
replace the <input> in the test with a <select>, or a <marquee>, or a
<details> element).

Avoid serializing UA widgets to fix it, I don't think we should expose
our internal shadow trees to webdriver.

I'm happy to change the test to use something different, or otherwise we
can just call this tested once bug 2016280 lands, your call.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f25261c8cec1
https://hg.mozilla.org/integration/autoland/rev/1342a5a5927e
[bidi] Don't serialize UA widgets. r=jdescottes

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 2016673 - [wdspec] Add browsingContext.locateNodes test to check user agent shadow roots are not returned

Comment 4

[Phabricator Automation]

Comment on attachment 9545001 [details]
Bug 2016673 - [wdspec] Add browsingContext.locateNodes test to check user agent shadow roots are not returned

Revision D283299 was moved to bug 2016738. Setting attachment 9545001 [details] to obsolete.

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1342a5a5927e