2016690 - Learn More link is not accessible via keyboard

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Giorgia Nichita, Release Desktop QA]

Found in:

• latest Nightly 149.0a1

Affected versions:

• latest Nightly 149.0a1

Tested platforms:

• Windows 11 with NVDA
• Ubuntu 24.04 with Orca

Steps to reproduce:

1. Navigate to about:translations.
2. Try to navigate to the “X” (clear source text) button in the input field using the keyboard.
3. Try to navigate to the Learn More link using the keyboard.

Expected:

• The “X” button and Learn More link should be reachable and operable via keyboard.

Actual:

• The “X” button and Learn More link are not accessible via keyboard.

Regression range:

• Not a regression.

Additional notes:

• Because these elements are not reachable via keyboard, screean readers do not read them.
• On Windows, NVDA reads the buttons but only on hover.

Comment 1

[Eitan Isaacson [:eeejay]]

Marking s2 because of keyboard inoperability

Comment 2

[Erik Nordin [:nordzilla]]

This is actually intentional behavior, which I discussed ahead of time with Anna.

The intent is that the source text and translated text are only one Tab/Shift + Tab away from each other.

Keyboard users can easily clear the text with Ctrl/Cmd + A then Delete, which is a common and universal pattern.

The clear-source-text button is more of a visual convenience feature, that would be in between the source text and translated text in the tab index, so it is excluded from the tab index entirely with intention.

Comment 3

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Confirming the x is not expected to be focusable with keyboard, similarly to the native data:text/html,<input type=search value=test> search input that would show the x control but this moz-search-clear-button would not be included in the focus order. It was discussed initially in the bug 1655503 and further in the bug 1936648, with bug 1055085 providing support for Esc to clear search inputs by default.

In this case, the x button is still exposed to assistive technology, so a voice control user would be able to activate this button, which is appropriate in this case.

@Erik, would that be possible to add Esc key support for clearing the inputs (while an input itself is focused, of course)? Not a blocker though.

---

Reopening this bug for the Learn more link focusability that is still present and not expected.

Seems like the hyperlink is not created because a valid href attribute is missing from the <a> anchor element, thus the element is clickable but not focusable or operable with keyboard in any other way.

Current Code:
<a id="about-translations-learn-more-link" is="moz-support-link" data-l10n-id="about-translations-learn-more-link" support-page="website-translation">Learn more</a>

Adding href="#" to the anchor resolves the issue.

Comment 4

[Erik Nordin [:nordzilla]]

Thank you Anna!

I have a fix for this D282206. It was just a drive-by fix that I added within a larger patch stack that is currently in review. Now that this bug is its focus, however, I will reassign the patch to this bug number.

---

@Erik, would that be possible to add Esc key support for clearing the inputs (while an input itself is focused, of course)? Not a blocker though.

I will file a bug for this and prioritize it after all of the mission-critical work. Shouldn't be difficult to do.

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: Bug 2016690 - Ensure primary learn-more link is focusible r=sfoster!

This commit ensures that the primary learn-more link on the page
is focusible via tab index.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9c5fc8e8172c
https://hg.mozilla.org/integration/autoland/rev/48d71828f42a
Ensure primary learn-more link is focusible r=sfoster

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ad604c5b4569
https://hg.mozilla.org/integration/autoland/rev/f3307d9c78de
Revert "Bug 2016690 - Ensure primary learn-more link is focusible r=sfoster" for causing bc failures @ browser_MLSuggest_integration.js

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_MLSuggest_integration.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f3307d9c78de4c7b20614a7fed6f41c3e248f281

Push with failures

Failure log -> browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js

Comment 9

[Erik Nordin [:nordzilla]]

This is part of a single backout that spanned multiple bugs.

In the patch stack, I increased the timeout when waiting for a mocked RemoteSettings model to download within our Translations tests, hoping that it might also help to reduce intermittent Translations test failures.

There are a few ml related tests that share our Remote Settings mocks. This test case happens to wait for the full duration of the timeout as part of the success path of the test case.

I've reverted the timeout change, and everything should hopefully be fine now.

I would one day like to either fully separate this code, or unify it in a way that ml doesn't rely on Translations under the hood, so that its more clear where the downstream consumers are.

Comment 10

[Erik Nordin [:nordzilla]]

Restoring the original timeout seems to have fixed the issue:

• https://hg.mozilla.org/try/rev/f90e8c8356a1b6f859b28cf430158700cbf43901
• https://treeherder.mozilla.org/jobs?repo=try&revision=c4b57d3456613bf4d05a01e04ce95a3679a2c8db

---

Attempting re-landing.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0d2917bb6500
https://hg.mozilla.org/integration/autoland/rev/9cb6a0ed4bb5
Ensure primary learn-more link is focusible r=sfoster

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/9cb6a0ed4bb5

Comment 13

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:nordzilla, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox149 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Erik Nordin [:nordzilla]]

While 149 is technically affected, the "official" feature release for the about:translations page is Firefox 150, so I don't think this needs to be uplifted.

Comment 15

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Windows 11, Ubuntu 24.04, and macOS 26 using the latest Nightly 150.0a1 build (20260311050622).
The Learn More link is now accessible via keyboard navigation and is correctly announced by screen readers on all tested operating systems.