201681 - split nsCSSDeclaration.h and .cpp

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I want to split nsCSSDeclaration.h and nsCSSDeclaration.cpp into
nsCSSDeclaration (for nsCSSDeclaration itself) and nsCSSStruct (for the values
and structs).  nsCSSStruct.h would be included all over the place.  This would
greatly reduce dependencies on nsCSSDeclaration.h and fix a header ordering
problem that I need to fix for bug 125246.

Do these filenames sound good?  If so, I'll want to do this in reasonably short
order (after requesting a repository-copy).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm....  Are the structs going to actually stay structs?

That is, maybe the second file should be nsCSSDataStorageTypes.h ?  (A little
long and unwieldy... :().

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

They're still going stay structs in some uses (nsRuleData, and the expanded,
mutable, form for bug 125246).  And the stuff for the others will mostly be in
other files (although I could move nsCSSRect, etc., to nsCSSValue.h or make a
new nsCSSValues.h, but I'd rather not).

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Given that, do you think my proposed names are ok?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Sounds good.  ;)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

To clarify, the repository copy would be (all within
mozilla/content/html/style/src/):
  copy nsCSSDeclaration.cpp to nsCSSStruct.cpp
  copy nsCSSDeclaration.h   to nsCSSStruct.h

Comment 6

[Daniel (Leaf) Nunes]

copy complete.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in, 2003-04-14 20:07 PDT.  (Post facto review would be nice,
although the changes are trivial (the complexity of a build bustage fix, really,
except that tons of lines were removed due to the split).  But I really wanted
to get them in before someone checked in to one of the files, and also before I
had to go into hiding for a week.)

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 120467 [details] [diff] [review]
patch

Er, I thought I'd marked review on this..... I definitely read over it and it
looked fine...

Maybe my Mozilla crashed around then....