201684 - application crashes when loading meta components

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[hacker formerly known as [e-mail]]

When using the meta components build options
(http://www.mozilla.org/build/static-builds.html#s2.3), the browser crashes on
startup now.  These options were last tested and known to be working on April 7th.

The meta module magic is handled at
http://lxr.mozilla.org/seamonkey/source/modules/staticmod/nsMetaModule.cpp.in
& 
http://lxr.mozilla.org/seamonkey/source/modules/staticmod/Makefile.in .

Comment 1

[hacker formerly known as [e-mail]]

Bah. http://www.mozilla.org/build/static-build.html#s2.3

Comment 2

[hacker formerly known as [e-mail]]

Hrm.  The dates of that objdir build was on the 7th but I if I go back, I can't
even get a usable build when pulling from "Wed Apr 2 9:00:00 PDT 2003" .  A
traditional static build works and a meta-component build links (when adding
xpcom_compat for meta_mail), but dies in nsGenericModule::RegisterSelf() when run.  

When using the mozilla 1.4a sources (which came from the 4/1 nightly build), the
meta-components build runs with the patch from bug 201602.  So it's looking like
one of the huge list of checkins from 4/1 broke this.

Comment 3

[hacker formerly known as [e-mail]]

Attachment: v1.0

Found the problem.  mLibraryDependencies was added to nsModuleInfo to track
external library dependencies but not all uses of nsModuleInfo were updated. 
We allocate a local nsModuleInfo struct on the stack so it never gets zero'd
out and mLibraryDependencies points to garbage.  I'm surprised this hasn't
broken before as that member was added some time ago.

Comment 4

[hacker formerly known as [e-mail]]

Attachment: v1.0

Found the problem.  mLibraryDependencies was added to nsModuleInfo to track
external library dependencies but not all uses of nsModuleInfo were updated. 
We allocate a local nsModuleInfo struct on the stack so it never gets zero'd
out and mLibraryDependencies points to garbage.  I'm surprised this hasn't
broken before as that member was added some time ago.

Comment 5

[hacker formerly known as [e-mail]]

Comment on attachment 120345 [details] [diff] [review]
v1.0

Cancelling submits doesn't work.

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 120346 [details] [diff] [review]
v1.0

okay. r=dougt.

Comment 7

[Doug Turner (:dougt)]

thanks seawood.

Checking in modules/staticmod/nsMetaModule.cpp.in;
/cvsroot/mozilla/modules/staticmod/nsMetaModule.cpp.in,v  <--  nsMetaModule.cpp.in
new revision: 1.3; previous revision: 1.2
done