2016849 - Refactor baseUrl defaults from null to undefined across security layer URL callchain

Status: RESOLVED WONTFIX

(Core :: Machine Learning: General, task)

Description

[Randy Concepcion]

The following methods methods in the security layer default baseUrl to null.:

• normalizeUrl
• TabLedger.seed
• TabLedger.has
• TabLedger.add

Due to this, the security layer uses a ternary guard in normalizeUrl because URL.parse(urlString, null) returns null even for valid URLs.
If the callchain used undefined instead of null, the second argument would simply be omitted naturally and the ternary would be unnecessary:

const url = URL.parse(urlString, baseUrl);

Acceptance Criteria:

• All baseUrl parameters in the security callchain default to undefined and the ternary guard in normalizeUrl is removed
• Existing tests continue to pass

Comment 1

[Greg Tatum [:gregtatum]]

This is being removed in Bug 2029729.