Profile delete page title should enclose profile name in quotes
Categories
(Toolkit :: Startup and Profile System, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox150 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jasub270, Mentored, NeedInfo)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
[Cloned from bug 2016932 - the difference is that this bug is about correcting the page title, shown in the tab, while the other bug focuses on the heading shown inside the page.]
For security reasons, we want to better separate parts of the UI that are user-generated from parts of the UI that belong to Firefox.
When a user has multiple profiles and clicks the "delete" button for one of them*, they are taken to the about:deleteprofile page. If the name of the profile is "My Profile", the page title of the about:deleteprofile page currently reads, Delete My Profile? but we want it to instead read Delete “My Profile”?, where the user-generated profile name is enclosed in quotes. Note we don't want to use the normal quote symbol ", but rather the unicode characters for open quote “ and close quote ”, because this distinction is important to our localization system.
To make this change, we'll need to update the string that renders the title of the delete page. We will also need to change the name of the string, because our localization system only exposes strings to our volunteer localizers when the string ID is new. (See the fluent tutorial for more details.)
To complete this task, you'll need to
- Figure out where in the Firefox source code you can find the source for the about:deleteprofile page
- Figure out the
l10n-idof the page's title - Find the
.ftlfile containing thatl10n-id - Update the string in the ftl file to enclose the
{ $profilename }variable in unicode open and close quotes, like“{ $profilename }”, then update the ID of that string to something different (just adding a-2at the end of the ID is fine). - Finally, update the code that renders the delete page title to change that element's
l10n-idattribute from the old ID to the new ID.
String changes aren't typically tested, so we'll likely skip that step here.
- For information on how to create multiple profiles and how to get to the profile delete page, see https://support.mozilla.org/en-US/kb/profile-management#w_delete-a-profile.
- Note that you'll need to use
./mach run -nin your local build, not./mach run, for the build to allow for creating multiple profiles.
|
Reporter | |
Updated•1 month ago
|
|
|
Reporter | |
Comment 2•1 month ago
|
||
Hey there! Thanks for your interest in contributing to Firefox. I'm happy to assign this bug to you. I'll add some more information from our good-first-bug template which I missed in the description. Start with these steps, and if you get stuck or need more guidance, you can needinfo me here (check the "Request information from" checkbox below the comment box and search for :jhirsch in the search box).
-
Download and build the Firefox source code
- If you have any problems, please ask on Element/Matrix in the
#introductionchannel. They're there to help you get started. - You can also read the Firefox Contributors' Quick Reference, which has answers to most development questions.
- If you have any problems, please ask on Element/Matrix in the
-
Start working on this bug.
- A good first step is to get a local build running, create additional profiles, then go to the about:deleteprofile page. Enable the browser toolbox and be sure to toggle the mode to "Multiprocess (slower)". This will allow you to inspect both the browser UI and the contents of the about:deleteprofile page.
- The bug description contains a list of bullet points which provide general guidance on things you'll need to figure out. I've deliberately left them a little bit vague to encourage you to explore the code and documentation :-) but please feel free to ask questions if you get stuck for more than half an hour or so.
- https://searchfox.org is the recommended tool to search through the Firefox source code.
- Note that, after you have built your changes with
./mach build, you'll need to run your build using./mach run -n, not plain./mach run, in order to use the multiple profiles feature. - Also, you can find me and my teammates in the
Firefox Profile Managementchannel on Element/Matrix most hours of most days. - Finally, because this change simply changes a string, we won't add tests as part of this bug.
-
Build your change with
mach buildand check your changes for adherence to our style guidelines by usingmach lint. -
Submit the patch for review.
Mark me as a reviewer so I'll get an email to come look at your code. -
After a series of reviews and changes to your patch,
I'll mark it for checkin.
Your code will soon be shipping to Firefox users worldwide! -
...now you get to think about what kind of bug you'd like to work on next.
Let me know what you're interested in and I can help you find your next contribution.
|
|
Reporter | |
Comment 3•1 month ago
|
||
Whoops, forgot to actually assign the bug...
Thanks for assigning this bug to me! I've submitted my patch for review. For my next contribution I'm interested in simple JavaScript logic bugs — do you have any recommendations in the profiles area or elsewhere?
|
|
Reporter | |
Comment 7•26 days ago
|
||
Hey Jocsan - I'm very sorry for the long delay in getting back to you. Your patch is approved, and I've queued it to land. It should land in Nightly in the next day or so. Congratulations! Thanks for contributing to Firefox :-)
For my next contribution I'm interested in simple JavaScript logic bugs — do you have any recommendations in the profiles area or elsewhere?
How about taking a look at the good-next-bugs on Codetribute--do any of these look interesting?
https://codetribute.mozilla.org/projects/firefox-frontend?tag%3Dgood-next-bug
|
||
Updated•26 days ago
|
|
||
Comment 9•25 days ago
|
||
| bugherder | ||
|
||
Updated•4 days ago
|
Description
•