2016950 - XUL prototype code calls into DoneCreatingElement() for already created elements

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

That caused some violation of invariants with https://phabricator.services.mozilla.com/D283423 which for now I'm just working around, but I plan to fix in this bug.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2016950 - PrototypeDocumentContentSink should use FROM_PARSER_NETWORK for non-XUL elements too. r=smaug!

It uses DoneAddingChildren / DoneCreatingElement, and nsXULElement also
does this.

Otherwise we can get into weird situations because the consumers might
not expect this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4ceb7c55a11a
https://hg.mozilla.org/integration/autoland/rev/1d37fe93b012
PrototypeDocumentContentSink should use FROM_PARSER_NETWORK for non-XUL elements too. r=smaug

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/da8cbbbcbfc4
https://hg.mozilla.org/integration/autoland/rev/423e33a3aa6f
Revert "Bug 2016950 - PrototypeDocumentContentSink should use FROM_PARSER_NETWORK for non-XUL elements too. r=smaug" for causing multiple failures.

Comment 4

[agoloman]

Backed out for causing multiple failures.

• Backout link
• Push with failures
• Failure Log @browser_advanced_update.js
• Failure Log @browser_markup_screenshot_node_about_page.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cced10961b53
https://hg.mozilla.org/integration/autoland/rev/7edce67f9460
PrototypeDocumentContentSink should use FROM_PARSER_NETWORK for non-XUL elements too. r=smaug

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7edce67f9460