Open Bug 2016967 Opened 1 month ago Updated 11 days ago

Text matched by find in page does not scroll into the view.

Categories

(Core :: Find Backend, defect)

Product:
Core
Component:
Find Backend
Platform:
Desktop
Windows 11
Type:
defect

Tracking

()

Status:
REOPENED
Tracking Flags:
Tracking Status
firefox-esr115 --- wontfix
firefox-esr140 --- wontfix
firefox147 --- wontfix
firefox148 --- wontfix
firefox149 --- wontfix

People

(Reporter: alice0775, Assigned: jjaschke, NeedInfo)

References

(Regressed 1 open bug, Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(2 files)

reducedtestcase.html
393.19 KB, text/html
Details
Bug 2016967 - Fix find-in-page not scrolling to sticky table cells by using natural frame position in ScrollFrameIntoView. r=emilio!
48 bytes, text/x-phabricator-request
Details | Review

Steps to reproduce:

  1. Open https://www.asahi.com/special/population2024/list/
  2. Scroll to bottom. (This step is important for reproducing the problem)
  3. Open Find in Page (Ctrl+F)
  4. Type 門真市 and Hit Enter

Actual results:
Find bar indicates 1/1 matches, but the matched text does not scroll to into view.

Expected results:
The matched text should scroll to into view.

Keywords: regression
Regressed by: 975644

Set release status flags based on info from the regressing bug 975644

:emilio, since you are the author of the regressor, bug 975644, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

status-firefox147: --- → affected
status-firefox148: --- → affected
status-firefox-esr140: --- → affected
Flags: needinfo?(emilio)

Hey Jan, please take a look at this, thanks.

Flags: needinfo?(emilio) → needinfo?(jjaschke)

Set release status flags based on info from the regressing bug 975644

status-firefox150: --- → affected
Assignee: nobody → jjaschke
Status: NEW → ASSIGNED
Pushed by jjaschke@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7f2a73e801c9 https://hg.mozilla.org/integration/autoland/rev/c85eec50ba58 Fix find-in-page not scrolling to sticky table cells by using natural frame position in ScrollFrameIntoView. r=emilio,layout-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58225 for changes under testing/web-platform/tests
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e5334107971e https://hg.mozilla.org/integration/autoland/rev/81776d37a3b0 Revert "Bug 2016967 - Fix find-in-page not scrolling to sticky table cells by using natural frame position in ScrollFrameIntoView. r=emilio,layout-reviewers" for causing web failures

Backed out for causing web failuers
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-PASS | /css/css-position/sticky/position-sticky-input-box-gets-focused-after-scroll.html | Focusing on visible sticky input box should reset the scroll to unshifted sticky position. - expected FAIL

Unexpected passes, my favorite reasons for getting backed out ...

Flags: needinfo?(jjaschke)
Pushed by jjaschke@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4c9eeb27d58d https://hg.mozilla.org/integration/autoland/rev/e48c5fc0508f Fix find-in-page not scrolling to sticky table cells by using natural frame position in ScrollFrameIntoView. r=emilio,layout-reviewers
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d75b14e0b9ec https://hg.mozilla.org/integration/autoland/rev/ed0415b74d61 Revert "Bug 2016967 - Fix find-in-page not scrolling to sticky table cells by using natural frame position in ScrollFrameIntoView. r=emilio,layout-reviewers" for causing wpt failures in scrollIntoView-stuck.tentative.html.

Reverted this because it was causing wpt failures in scrollIntoView-stuck.tentative.html.

  • Revert link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | /css/cssom-view/scrollIntoView-stuck.tentative.html | CSSOM View - scrollIntoView doesn't consider scroll-padding when target is stuck - assert_equals: Shouldn't have scrolled expected 0 but got 4568
Flags: needinfo?(jjaschke)
Upstream PR merged by moz-wptsync-bot
Pushed by jjaschke@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/52fe9a311835 https://hg.mozilla.org/integration/autoland/rev/4571d08deb56 Fix find-in-page not scrolling to sticky table cells by using natural frame position in ScrollFrameIntoView. r=emilio,layout-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58255 for changes under testing/web-platform/tests
Flags: needinfo?(jjaschke)

https://hg.mozilla.org/mozilla-central/rev/4571d08deb56

Status: ASSIGNED → RESOLVED
Closed: 20 days ago
status-firefox150: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
Upstream PR merged by moz-wptsync-bot

The patch landed in nightly and beta is affected.
:jjaschke, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(jjaschke)

Don't think this requires uplift.

status-firefox148: fix-optional → wontfix
status-firefox149: affected → wontfix
Flags: needinfo?(jjaschke)
Regressions: 2021684
Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/07345fc32c0d https://hg.mozilla.org/integration/autoland/rev/0b546fe006b5 Revert "Bug 2016967 - Fix find-in-page not scrolling to sticky table cells by using natural frame position in ScrollFrameIntoView. r=emilio,layout-reviewers" by dev request

backed out by request: https://hg.mozilla.org/integration/autoland/rev/0b546fe006b5d3aff0c9b8868775eff3c52a006a

Status: RESOLVED → REOPENED
status-firefox150: fixed → ---
Flags: needinfo?(jjaschke)
Resolution: FIXED → ---
Target Milestone: 150 Branch → ---
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58478 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: