2017428 - [FE] Settings: split “Learn from your activity” into separate chat + browsing memory generation toggles

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, enhancement, P1)

Description

[Justin Levinsohn]

Attachment: image.png

Update Settings > AI controls > Smart Window > Memories to give users explicit control over which surfaces Firefox learns from to generate memories.

Current UI (single control):
“Learn from your activity. Smart Window can use your browsing and chat activity to create memories and personalize responses.”

New UI (two controls):
• “Learn from my chat activity in Smart Window”
• “Learn from my browsing activity in Classic and Smart Windows”
(plus existing “Manage memories” row remains)

Frontend scope:
• Replace the single toggle with two independent toggles/checkbox rows in the Memories section (per updated Figma)
• Wire each control to the new prefs from Bugzilla (one for chat-based memory generation, one for browsing-based memory generation)
• Ensure state persists and reflects pref values on load
• Copy should match spec and be clear about scope (Smart vs Classic + Smart)

Pref migration note (Nightly testers):
There was discussion about migrating the old single pref into the new two-pref model. For MVP, product direction is to keep it simple: do not add migration complexity; introduce the 2 new prefs and do not attempt to map the legacy value (follow-up can revisit post-MVP/foxfooding if needed).

Acceptance Criteria
• Settings > AI controls > Smart Window > Memories shows two separate controls (chat + browsing) per updated design
• Each control reads/writes the correct underlying pref (chat pref from 2017329, browsing pref from 2017327)
• Toggling either control updates UI state immediately and persists across restart/reopen of Settings
• No regressions to “Manage memories” navigation
• No migration logic required for MVP (legacy single-toggle pref is not mapped)

Backend/prefs work is tracked separately and already filed:
• 2017327 – pref for generating memories from browsing history on/off
• 2017329 – pref for generating memories from chat on/off

Comment 5

[Ed Lee :Mardak]

bug 2017327 adds the new prefs and we should remove browser.smartwindow.memories old pref when we clean up the references with this bug. we will need to update the smartbar display of memory toggle from

https://searchfox.org/firefox-main/rev/a9978f78a4d470a05774e72b167db95082be5a54/browser/components/aiwindow/ui/components/ai-window/ai-window.mjs#80

Comment 7

[Chloe Zhou [:chloezhou]]

Attachment: Bug 2017428 - Settings: split “Learn from your activity” into separate chat + browsing memory generation toggles r=pdahiya

Replace the single "Learn from your activity" toggle in Settings > AI controls > Smart Window > Memories with two independent checkboxes:
"Learn from chats in Smart Window" (browser.smartwindow.memories.generateFromConversation)
"Learn from browsing in Classic and Smart Windows" (browser.smartwindow.memories.generateFromHistory)

Each control reads/writes its own pref, persists across restart, and updates UI state immediately. The "Manage memories" navigation is unchanged. No migration from the legacy single-toggle pref (browser.smartwindow.memories) is needed for MVP.

Add a label slot fallback to MozBaseInputElement.labelTemplate() so moz-checkbox can render rich-text labels via Fluent DOM overlays, enabling bold on specific words within the label.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e003e5debc61
https://hg.mozilla.org/integration/autoland/rev/51250c005901
Settings: split “Learn from your activity” into separate chat + browsing memory generation toggles r=pdahiya,fluent-reviewers,sessionstore-reviewers,ai-frontend-reviewers,flod,sthompson

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/51250c005901