201743 - cookie confirmation dialog lacks accelerators for accept/deny buttons (keyboard shortcuts, hotkeys)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement)

Description

[Stephen Granade]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b; MultiZilla v1.1.32 final) Gecko/20030401
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b; MultiZilla v1.1.32 final) Gecko/20030401

The Confirm dialog for accepting/denying cookies lacks accelerators. While there
are accelerators for the _S_how Details and _H_ide Details buttons, there are
none for the Accept and Deny buttons (nor were there for the Yes/No buttons in
prior Mozilla builds).

Reproducible: Always

Steps to Reproduce:
1. In Preferences->Privacy & Security->Cookies, make sure that "Ask me before
storing a cookie" is checked.
2. Visit a site which will set a cookie, one which you have not visited before.
(For example, http://webreference.com/js/tips/020110.html)
3. The Confirm dialog will appear. The Accept and Deny buttons will lack
accelerators.

Actual Results:  
A Confirm dialog appears, but lacks any accelerators for Accept or Deny.

Expected Results:  
In the Confirm dialog box, _A_ccept and _D_eny should have accelerators on the
first letters.

Chrome skin.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

You can use enter and esc, a common way of closing dialogs.

Comment 2

[Stephen Granade]

Sure, but ENTER defaults to "Yes/Accept." What I want is an easy way to select
"No/Deny" from the keyboard. Right now that involves a fair amount of pressing
TAB or SHIFT-TAB to hilight "No/Deny". That aside, from a consistent UI
standpoint, it'd be good for such dialogs to have accelerators for all of its
options, not just "Show/Hide Details".

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

*** Bug 204311 has been marked as a duplicate of this bug. ***

Comment 4

[Dan Mellem]

Verified that ESC can be used for Deny and Return/Enter for Allow in Windows.
However, there aren't the normal hotkeys (and underlined letter) as there are on
most menus and dialogs. Also, there's no hotkey for the "Use my choice for all
cookies from this site" checkbox. I think that being able to hit a single letter
will be more obvious, especially for new users.

Perhaps:
_A_llow
_D_eny
_U_se my choice for all cookies from this site
Show De_t_ails
Hide De_t_ails

This way 'T' could be used as a toggle.

Comment 5

[Patrick Bores]

Confirmed. Pressing "Escape" does not honor the "Use my choice for all
cookies from this site" checkbox. It seems to me it _used_ to, but no longer
does. When I press the "Deny" button, the checkbox is honored. It's inconsistent.
 

Comment 6

[[e-mail]]

>Confirmed. Pressing "Escape" does not honor the "Use my choice for all
>cookies from this site" checkbox. It seems to me it _used_ to, but no longer
>does. When I press the "Deny" button, the checkbox is honored. It's inconsistent.

Yes, we made that change intentionally - pressing esc or closing the dialog via
the 'x' button is a means of aborting the dialog, not providing a response. The
solution is to provide proper default keys for the two options & checkbox.

Comment 7

[Jesse Ruderman]

*** Bug 208760 has been marked as a duplicate of this bug. ***

Comment 8

[[e-mail]]

Attachment: patch v1

this adds accesskeys for the (A)ccept, (D)eny, and 'show/hide de(T)ails'
buttons. pressing alt+key will trigger them. 'U' already exists for 'use my
choice for...'.

due to the buttons not having focus when the checkbox is initially displayed,
just pressing the accesskey for a button (without alt) won't work. if someone
has a nice solution for that, it would be handy...

Comment 9

[[e-mail]]

oh, there is a random string change in there too, to make it consistent with the
others :)

Comment 10

[[e-mail]]

Comment on attachment 133121 [details] [diff] [review]
patch v1

Neil, mind taking a look? thx!

Comment 11

[Michiel van Leeuwen (email: mvl+moz@)]

*** Bug 220508 has been marked as a duplicate of this bug. ***

Comment 12

[Alec Flett]

Comment on attachment 133121 [details] [diff] [review]
patch v1

sr=alecf

Comment 13

[[e-mail]]

-> me

Comment 14

[[e-mail]]

checked in.