Closed Bug 2017448 Opened 8 months ago Closed 4 months ago

Use CSSNumberish for Animation.startTime

Categories

(Core :: DOM: Animation, task)

task
Points:
2

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: boris, Assigned: jwatt)

References

()

Details

(Whiteboard: [scrollanimation:mvp] )

Attachments

(1 external file)

The interface of Animation now uses CSSNumberish:

[Exposed=Window]
partial interface Animation {
    attribute CSSNumberish?       startTime;
    ...
};

Here is the webidl code. We will update other attributes in separate bugs.

Also, we have to use the algorithm provided by the spec to validate a CSSNumberish time when setting the start time.

Summary: Use CSSNumberish for AnimationTimeline.startTime → Use CSSNumberish for Animation.startTime
Whiteboard: [scrollanimation:mvp]
Points: --- → 2
Assignee: nobody → mozmail
Status: NEW → ASSIGNED
Pushed by jwatt@jwatt.org: https://github.com/mozilla-firefox/firefox/commit/925b34ae9fd4 https://hg.mozilla.org/integration/autoland/rev/3c55baaefb7e Use CSSNumberish for Animation.startTime. r=boris,webidl,layout-scroll-driven-animation-reviewers,smaug
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Type: enhancement → task
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: