2017449 - Improve about:translations test events

Status: RESOLVED FIXED

(Firefox :: Translations, task)

Description

[Erik Nordin [:nordzilla]]

Description

The about:translations page fires some events that are intended to help tests precisely track the flow of execution through the UI.

We should ensure that these events no-op and are not fired when we are not running in automation, so as not to add unneeded event calls while the page is running in production.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 2017449 - Rework about:translations test events r=#translations-reviewers!

This commit reworks the test-only events fired by the about:translations
page, which help us adhere to precise event-based timing throughout tests,
to truly be fired as test-only events, instead doing a no-op if we are
not in automation.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 2017449 - Rework about:translations test events r=sfoster!

This commit reworks the test-only events fired by the about:translations
page, which help us adhere to precise event-based timing throughout tests,
to truly be fired as test-only events, instead doing a no-op if we are
not in automation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c9667279b2c5
https://hg.mozilla.org/integration/autoland/rev/593ebf53e86e
Rework about:translations test events r=sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/acb6f5bce700
https://hg.mozilla.org/integration/autoland/rev/6dfad38f2a7f
Revert "Bug 2017449 - Rework about:translations test events r=sfoster" for causing bc failures @ browser_MLSuggest_integration.js

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_MLSuggest_integration.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/6dfad38f2a7f1c143a472c68071dc8adfc1fd1ef

Push with failures

Failure log -> browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js

Comment 6

[Erik Nordin [:nordzilla]]

This is part of a single backout that spanned multiple bugs.

In the patch stack, I increased the timeout when waiting for a mocked RemoteSettings model to download within our Translations tests, hoping that it might also help to reduce intermittent Translations test failures.

There are a few ml related tests that share our Remote Settings mocks. This test case happens to wait for the full duration of the timeout as part of the success path of the test case.

I've reverted the timeout change, and everything should hopefully be fine now.

I would one day like to either fully separate this code, or unify it in a way that ml doesn't rely on Translations under the hood, so that its more clear where the downstream consumers are.

Comment 7

[Erik Nordin [:nordzilla]]

Restoring the original timeout seems to have fixed the issue:

• https://hg.mozilla.org/try/rev/f90e8c8356a1b6f859b28cf430158700cbf43901
• https://treeherder.mozilla.org/jobs?repo=try&revision=c4b57d3456613bf4d05a01e04ce95a3679a2c8db

---

Attempting re-landing.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6fa89a6757d6
https://hg.mozilla.org/integration/autoland/rev/457d5d90de8f
Rework about:translations test events r=sfoster

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/457d5d90de8f