Closed Bug 2017458 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 57845 - Fix focus ring for anchor elements

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
150 Branch
Tracking Status
firefox150 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 57845 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/57845
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Fix focus ring for anchor elements

Anchor elements have special behavior to prevent a focus ring from being
rendered when the last user focus was done via keyboard and it was then
focused via script, which was (probably) added here: https://issues.chromium.org/issues/40383506

This inconsistency with other keyboard focusable elements is not a good
thing, and I don't agree with the justification from the bug report
which added the inconsistency, so this patch removes the special
behavior by removing HTMLAnchorElementBase::ShouldHaveFocusAppearance.

Fixed: 40848191
Bug: 40383506, 40911863
Change-Id: Ifa80ca5596c4eec4a4ddd31338525668a77137d1

Reviewed-on: https://chromium-review.googlesource.com/6354078
WPT-Export-Revision: f9f7154725b352d3d2f566d7caa83e43eb9f24d3

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 159 tests

Status Summary

Firefox

OK : 155
PASS: 2[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 334[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 335[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug] 336[Gecko-windows11-64-24h2-opt]
FAIL: 1[GitHub] 176[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-opt] 177[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug]

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
You need to log in before you can comment on or make changes to this bug.