2017746 - `./mach configure` always re-runs `./mach taskgraph` via `toolchain_task_definitions()` even if nothing has changed on disk

Status: NEW

(Firefox Build System :: General, defect, P2)

Description

[Alex Hochheiden [:ahochheiden] [he/him]]

On Windows, this is ~8-9 seconds on subsequent ./mach configure runs, taking up a substantial amount of the overall runtime. We should be able to cache this result with minimal effort by just hashing the contents of taskcluster/ and only re-running when there are changes.

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2017746 - Add `mach_func_cache` decorator for persistent function result caching r?#build

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2017746 - Cache `toolchain_task_definitions()` with `mach_func_cache` to speed up subsequent configure runs when there are no `taskcluster` or `toolchain-resources` changes r?#build

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahochheiden, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a78d7bbbaf81
https://hg.mozilla.org/integration/autoland/rev/16d1d9e52e52
Add `mach_func_cache` decorator for persistent function result caching r=firefox-build-system-reviewers,sergesanspaille,glandium
https://github.com/mozilla-firefox/firefox/commit/6be7acf6dc97
https://hg.mozilla.org/integration/autoland/rev/fcb933d373e2
Cache `toolchain_task_definitions()` with `mach_func_cache` to speed up subsequent configure runs when there are no `taskcluster` or `toolchain-resources` changes  r=firefox-build-system-reviewers,glandium