2017843 - Port addEngine, context and default tests to new searchbar

Status: RESOLVED FIXED

(Firefox :: Address Bar, task)

Description

[Moritz Beier [:mbeier]]

Splitting this out of bug 2009436 so this can land in 149.

This also fixes a minor cosmetic issue where the go button kept showing when reverting the new searchbar via escape.

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 2017843 - Part 1: Port browser_searchbar_addEngine.js to new searchbar. r?dao

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 2017843 - Part 2: Port browser_searchbar_context.js to new searchbar. r?dao

This also removes promiseContextualMenuitem from the urlbar test head file and replaces it by methods in UrlbarTestUtils that can be used by the url and searchbar.

Comment 3

[Moritz Beier [:mbeier]]

Attachment: Bug 2017843 - Part 3: Port browser_searchbar_default.js to new searchbar. r?dao

This also fixes a minor cosmetic issue where the go button kept showing when reverting the new searchbar via escape.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/789600c7ddbb
https://hg.mozilla.org/integration/autoland/rev/c284412e9285
Part 1: Port browser_searchbar_addEngine.js to new searchbar. r=dao,urlbar-reviewers
https://github.com/mozilla-firefox/firefox/commit/42071d95dc5a
https://hg.mozilla.org/integration/autoland/rev/3d0fda5dd2a0
Part 2: Port browser_searchbar_context.js to new searchbar. r=dao,urlbar-reviewers
https://github.com/mozilla-firefox/firefox/commit/c367ef21c56c
https://hg.mozilla.org/integration/autoland/rev/61170e46a198
Part 3: Port browser_searchbar_default.js to new searchbar. r=dao,urlbar-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c284412e9285

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3d0fda5dd2a0
https://hg.mozilla.org/mozilla-central/rev/61170e46a198