2017989 - [Models] [Search Handoff] Assistant is making 15+ search toolcalls in a row with select queries esp w/ duckduckgo

Status: VERIFIED FIXED

(Core :: Machine Learning: General, enhancement)

Description

[Tim Burrell]

Assistant makes 15+ search toolcalls in a row for this query: https://mozilla.slack.com/archives/C0ADUFX0QRW/p1771523842601919?thread_ts=1771520791.301559&cid=C0ADUFX0QRW

This might be a problem with other search providers as well.

Comment 1

[Ed Lee :Mardak]

potentially content from duckduckgo with very long links is confusing the llm? this is currently doing pageExtractor.getReaderModeContent bug 1990614

https://searchfox.org/firefox-main/rev/0fce12de99c5e7d74536d8f93cf9778ce6199a1f/browser/components/aiwindow/models/Tools.sys.mjs#452

Comment 2

[Tim Burrell]

this is easy to reproduce by asking to search for multiple things, e.g., “find me shoes and seattle weather”

Comment 3

[Tyler Etchart [:tetchart]]

Check function description for get_open_tabs:

"Access the user's browser and return a list of most recently browsed tabs. Each tab is represented by a JSON with the page's url, title and description if available. Default to return maximum 15 tabs."

May be related.

Comment 4

[again]

Attachment: WIP: Bug 2017989 - Limit run_search to one execution per user message turn

.

Comment 5

[again]

Attachment: WIP: Bug 2017989 - Dismiss searching indicator after normal stream completion

.

Comment 6

[again]

Attachment: WIP: Bug 2017989 - Limit run_search to one execution per user message turn

.

Comment 7

[again]

Attachment: Bug 2017989 - Limit run_search to one execution per user message turn

Guard duplicate run_search tool calls within the same user message turn in fetchWithHistory(). When the model requests run_search after one has already executed for the current turn, the guard returns an error tool result instead of executing the search and navigating the browser. The model continues generating text and can search again on the next user message.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6db9ddbfe27c
https://hg.mozilla.org/integration/autoland/rev/d99c7a8657b3
Limit run_search to one execution per user message turn r=ai-models-reviewers,cdipersio

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d99c7a8657b3

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d99c7a8657b3

Comment 11

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 150.0b1 and our latest Nightly build 151.0a1 (2026-03-26), I tried this with Bing, Google as well as duck duck go and I'm getting suggestions each time without any search hand-offs.