2018009 - Update IPP uses of BANDWIDTH.MAX_IN_GB to be based on usageInfo

Status: RESOLVED FIXED

(Firefox :: IP Protection, task, P2)

Description

[Fred Chasen [:fchasen]]

Anywhere we are using the constant MAX_IN_GB should be replaced by the max returned from Guardian. Currently we are using lazy.IPPProxyManager.usageInfo.max in the panel, but that won't be available until the proxy has started for the first time so we may need to use max returned with the entitlement before it.

Comment 1

[kpatenio]

Let's also update this hardcoded value in https://searchfox.org/firefox-main/rev/b824aa1f1416b2e3675f7561cb58f5568f4f156a/browser/components/ipprotection/IPProtectionAlertManager.sys.mjs#67.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 2018009 - Max bandwidth should check usage info and entitlement before defaulting to MAX_IN_GB. r=#ip-protection-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9517e4b00e4f
https://hg.mozilla.org/integration/autoland/rev/3a13b7a6f155
Max bandwidth should check usage info and entitlement before defaulting to MAX_IN_GB. r=ip-protection-reviewers,fchasen

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e8dfd26da490
https://hg.mozilla.org/integration/autoland/rev/40cb6d51aa0b
Revert "Bug 2018009 - Max bandwidth should check usage info and entitlement before defaulting to MAX_IN_GB. r=ip-protection-reviewers,fchasen" for causing bc failures @ browser_ipprotection_alert_manager.js

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_ipprotection_alert_manager.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/40cb6d51aa0b5aaf66c75e3c57bee460c627e3e9

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/ipprotection/tests/browser/browser_ipprotection_alert_manager.js

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9fa7b8332962
https://hg.mozilla.org/integration/autoland/rev/0d790fc26074
Max bandwidth should check usage info and entitlement before defaulting to MAX_IN_GB. r=ip-protection-reviewers,fchasen

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0d790fc26074

Comment 8

[Valentina Virlics [:vvalentina], VPN QA]

Is there something QA needs to verify here? Thanks!

Comment 9

[Fred Chasen [:fchasen]]

I don’t think so, this was just replacing the defaults for bandwidth sizes so shouldn’t be user facing.

Comment 10

[Michael Hynson]

Attachment: Bug 2018009 - Max bandwidth should check usage info and entitlement before defaulting to MAX_IN_GB.

Original Revision: https://phabricator.services.mozilla.com/D284487

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f074cc951d35
https://hg.mozilla.org/releases/mozilla-beta/rev/d165acfeb9c1