201818 - Convert long_list.cgi to a format

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Bradley Baetz (:bbaetz)]

The changes I made for bug 171493 and bug 158499 added formats to show_bug, to
have a generic front end for all the various formats we have.

The long_list code hasn't been moved yet. This is an issue because its template
is show-multiple.html.tmpl, and so show_bug.cgi with a format of 'multiple'
loads the template, but then errors out because the API isn't the same. We don't
link to anything that way, mind you, but its still a minor issue.

In any event, this should be moved across. It may be better to do this as a
buglist.cgi format rather than a show_bug format, so that we can grab all the
data in one query rather than multiple ones (for perf reasons). long_list
doesn't do that currently, though, so if it becomes a pain I won't do that here.

Comment 1

[Dave Miller [:justdave]]

You can't do it in buglist because then you lose all the "one to many" fields. 
(like CCs and deps and the comments).

Comment 2

[Bradley Baetz (:bbaetz)]

I said _like_ buglist.cgi. I can grab the multi-stuff out in spearate queries,
but the single stuff out in one. Or something like that.

I don't think I can do better in mySQL, at least not without tons of overhead. I
want to |SELECT bugs.bug_id, op_sys, etc, CURSOR(SELECT * from longdescs WHERE
bug_id=bugs.bug_id), CURSOR(SELECT * from dependancies...) WHERE
<Bugzilla::Search conditons>|, or something along those lines.

Comment 3

[Bradley Baetz (:bbaetz)]

This is easier to do in show_bug, by a long way.

Anyway, I've done this, but it interacts with both my User.pm patches and my
cgi.pm patches, so I won't post it until they're checked in.

Comment 4

[Rob Siklos [:robzilla]]

Attachment: rsiklos_v1

Here's a patch for 2.19.1.  Changes are quite minor.

Comment 5

[Rob Siklos [:robzilla]]

Comment on attachment 163850 [details] [diff] [review]
rsiklos_v1

missing from the patch is the need to delete long_list.cgi

Comment 6

[Rob Siklos [:robzilla]]

Attachment: rsiklos_v2

this patch removes long_list.cgi

Comment 7

[Gervase Markham [:gerv]]

IMO, long_list.cgi should be replaced with a redirection to the new format, to
avoid breaking bookmarks etc.

Gerv

Comment 8

[Rob Siklos [:robzilla]]

Attachment: rsiklos_v3

New patch makes long_list.cgi redirect to show_bug.cgi with the appropriate
parameter changes

Comment 9

[Marc Schumann [:Wurblzap]]

Comment on attachment 164252 [details] [diff] [review]
rsiklos_v3

Good patch.

Index: template/en/default/list/list.html.tmpl
===================================================================
RCS file:
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v
retrieving revision 1.27
diff -u -r1.27 list.html.tmpl
--- template/en/default/list/list.html.tmpl	21 Oct 2004 19:02:30 -0000     
1.27
+++ template/en/default/list/list.html.tmpl	2 Nov 2004 02:46:06 -0000
@@ -129,8 +129,11 @@
   <tr>
     [% IF bugs.size > 0 %]
       <td valign="middle">
-	 <form method="post" action="long_list.cgi">
-	   <input type="hidden" name="buglist" value="[% buglist %]">
+	 <form method="post" action="show_bug.cgi">
+	   [% FOREACH id = buglist %]
+	     <input type="hidden" name="id" value="[% id %]">

Make that [% id FILTER html %] and it's a go.

Comment 10

[Rob Siklos [:robzilla]]

Attachment: rsiklos_v4

Comment 11

[Dave Miller [:justdave]]

holding approval for the 2.20 branch creation.  This will go on the trunk after
2.20 branches.

Comment 12

[Vlad Dascalu]

Targeting bug to 2.20 since the 2.20 feature freeze was canceled.

Comment 13

[Shane H. W. Travis]

Comment on attachment 166338 [details] [diff] [review]
rsiklos_v4

Due to the feature freeze and the amount of activity on the trunk, there is
some bitrot in this patch now. 

patch -p0 < ~travis/201818-4.patch.txt
patching file buglist.cgi
Hunk #1 succeeded at 863 (offset 7 lines).
patching file long_list.cgi
Hunk #1 FAILED at 22.
1 out of 1 hunk FAILED -- saving rejects to file long_list.cgi.rej
patching file template/en/default/bug/knob.html.tmpl
Hunk #1 succeeded at 168 (offset 3 lines).
patching file template/en/default/bug/show-multiple.html.tmpl
Hunk #1 succeeded at 89 (offset -1 lines).
Hunk #2 succeeded at 197 (offset 7 lines).
patching file template/en/default/global/site-navigation.html.tmpl
patching file template/en/default/list/list.html.tmpl

If you could fix this, I will review it and check it in ASAP.

Comment 14

[Rob Siklos [:robzilla]]

Attachment: rsiklos_v5

ok, here's an updated patch.

Comment 15

[:glob ✱]

Comment on attachment 172006 [details] [diff] [review]
rsiklos_v5

r=glob
looks good to me.

Comment 16

[Shane H. W. Travis]

Forgot the CVS log.

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.273; previous revision: 1.272
done
Checking in long_list.cgi;
/cvsroot/mozilla/webtools/bugzilla/long_list.cgi,v  <--  long_list.cgi
new revision: 1.43; previous revision: 1.42
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
  knob.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/bug/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show-
multiple.html.tmpl,v  <--  show-multiple.html.tmpl
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/global/site-navigation.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/site-
navigation.html.tmpl,v  <--  site-navigation.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/list/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v  <-
-  list.html.tmpl
new revision: 1.28; previous revision: 1.27
done

Comment 17

[:glob ✱]

Attachment: v6

same as previous patch, with and update to filterexceptions

Comment 18

[Shane H. W. Travis]

Tinderbox is burning on checkin of this patch: 

ok 51 - (en/default) list/list.csv.tmpl is filter-safe
not ok 52 - (en/default) template/en/default/list/list.html.tmpl - 
filterexceptions.pl has extra members:
  buglist
--WARNING
#     Failed test (t/008filter.t at line 142)


Failed Test   Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/008filter.t    1   256   192    1   0.52%  52


Backing out the v5 patch. Glob has already got a v6 patch looking for review, 
it seems.

Comment 19

[Marc Schumann [:Wurblzap]]

Comment on attachment 172233 [details] [diff] [review]
v6

(In reply to comment #17)
> same as previous patch, with and update to filterexceptions

Yes.
No complaints from runtests.pl any more.

Comment 20

[Shane H. W. Travis]

Tests all pass with the new patch, re-closing this one.

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.275; previous revision: 1.274
done
Checking in long_list.cgi;
/cvsroot/mozilla/webtools/bugzilla/long_list.cgi,v  <--  long_list.cgi
new revision: 1.45; previous revision: 1.44
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <-
-  filterexceptions.pl
new revision: 1.30; previous revision: 1.29
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--
  knob.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/bug/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show-
multiple.html.tmpl,v  <--  show-multiple.html.tmpl
new revision: 1.24; previous revision: 1.23
done
Checking in template/en/default/global/site-navigation.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/site-
navigation.html.tmpl,v  <--  site-navigation.html.tmpl
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/list/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v  <-
-  list.html.tmpl
new revision: 1.30; previous revision: 1.29
done

Comment 21

[Vlad Dascalu]

Comment on attachment 172006 [details] [diff] [review]
rsiklos_v5

v5 is known to break the tree, marking review- on it.