2018337 - Firefox 148.0 does not compile with gcc 15.2.1

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Bojan Smojver]

User Agent: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/145.0.0.0 Mobile Safari/537.36

Steps to reproduce:

Attempted to compile Firefox 148.0 with gcc 15.2.1 on Fedora 43, in copr. See:

https://copr.fedorainfracloud.org/coprs/bojan/FF/build/10151262/
https://src.fedoraproject.org/rpms/firefox/pull-request/101

A patch to include dstdint header was required in select files.

Actual results:

The builds would error with undefined types.

Expected results:

Previous stable version of Firefox, 147.0.4 didn't have the same issue.

The patch to fix compilation is here:

https://src.fedoraproject.org/fork/bojan/rpms/firefox/blob/cd001f00b0abaa49a09e2e0d74720f5def1cf915/f/dstdint-compile-error.patch

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Bojan Smojver]

Yeah, definitely not about Android. Fedora is a general Linux distribution.

Comment 3

[Tooru Fujisawa [:arai]]

Thank you for your bug report.

toolkit/crashreporter/breakpad-client/linux/handler/minidump_descriptor.h is fixed by bug 2012200
TestIntegerRange.cpp and TestSmallPointerArray.cpp are fixed by bug 2008694.
TestArray.cpp, TestNotNull.cpp, and TestSPSCQueue.cpp are not fixed.

For the last three files, can you submit your patch by following https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html ?
That way the patch is properly attributed to you (the author information in the git commit).

Comment 4

[Bojan Smojver]

Hi Tooru,

Thanks for having a look. I created a PR on GitHub: https://github.com/mozilla-firefox/firefox/pull/71

Let me know if you need anything else,
Bojan

Comment 5

[Bojan Smojver]

BTW, I do not care about attribution. This is a trivial compilation fix, so just wanted to let you know.

Comment 6

[Tooru Fujisawa [:arai]]

Thank you for your patch.

Then, I'm really sorry but GitHub PR support is still under experimentation, and the repository doesn't yet accept PRs from everyone.

The contribution document explains how to submit the patch to Phabricator to get reviewed.
If you can submit the patch there, it will be great.
If it's too troublesome for you, don't worry, we'll handle it.

Comment 7

[Bojan Smojver]

Feel free to handle it Tooru. I haven't done a contribution via phabricator before, so this is a bridge too far for this simple compilation fix. 😁

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 2018337 - Fix compilation with gcc 15.2.1. r?sylvestre!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/072cc201380a
https://hg.mozilla.org/integration/autoland/rev/5831acc534db
Fix compilation with gcc 15.2.1. r=sylvestre

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5831acc534db