Status

()

Firefox
Address Bar
--
critical
VERIFIED FIXED
15 years ago
15 years ago

People

(Reporter: Ben Goodger (use ben at mozilla dot org for email), Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

unspecified
Firebird0.6
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Two bugs that I run into all the time with autocomplete that really piss me off:

1) Satchel (and sometimes urlbar) has a habit of crashing occasionally after
long periods of usage, or implicated with sites like imdb (urlbar in that case).
Something focus related. Threw in a null check, a NS_WARNING, and a graceful abort. 

2) Satchel ignores autocomplete="off" on textfields as specified by sites for
fields which contain sensitive data e.g. credit card info. 

Attaching a patch that I think fixes both of these. Could someone test.
-> me
Assignee: hewitt → ben

Comment 3

15 years ago
Ben, the autocomplete crash is bug 184202.

Comment 4

15 years ago
I realize now that your patch doesn't really fix bug 184202, it just avoids
crashing. This is a nice temporary workaround, but bug 184202 should still be
open when this is checked in.

Sorry for the bugspam.
Would be good to get this stuff into Fb 0.6. I'll get Asa to test this for me.
Status: NEW → ASSIGNED
Target Milestone: --- → Phoenix0.6
.
Severity: normal → critical

Comment 7

15 years ago
marking fixed.
I think most of the issues due to the bookmark landing in seamonkey are now
fixed. But a detailed QA is needed here. I still have to sync the
nsBookmarksService.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 8

15 years ago
sh*t wrong bug, reopening
sorry for the spam.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 9

15 years ago
I'll test the patch and QA these two issues rsn.
I've checked this patch in. It seemed to do the trick for me, but I would like
to hear from others. Asa is testing atm, others should be able to get this in
nightly builds. 
Status: REOPENED → RESOLVED
Last Resolved: 15 years ago15 years ago
Resolution: --- → FIXED

Comment 11

15 years ago
*** Bug 194581 has been marked as a duplicate of this bug. ***
Created attachment 121468 [details] [diff] [review]
the 194581 bit afaict

fwiw, this would appear to fix one particular reason it crashed, see bug 194581
comment 14
Comment on attachment 121468 [details] [diff] [review]
the 194581 bit afaict

...feel free if this looks useful/correct
Attachment #121468 - Flags: review?(ben)

Comment 15

15 years ago
Comment on attachment 121468 [details] [diff] [review]
the 194581 bit afaict

removing obsolete review request
Attachment #121468 - Flags: review?(ben)
You need to log in before you can comment on or make changes to this bug.