2018538 - Tweak rules view to ease supporting incremental updates

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task)

Description

[Alexandre Poirot [:ochameau] PTO, back August 11th]

For now the CssRuleView class wipes its whole content on most updates, which causes many troubles regarding user focus.
We have to restore user focus when updating, whereas the actual element where the focus is doesn't need any update.

A simplification regarding "containers" would help supporting incremental updates.
Right now pseudo elements, inherited, keyframes, registered properties and position-try all follow a similar pattern with expandable containers.
But regular rules don't.
This discrepency makes it significantly harder to update the list of rules incrementally.

Comment 1

[Alexandre Poirot [:ochameau] PTO, back August 11th]

Attachment: Bug 2018538 - [devtools] RuleEditor: Factorize all container logic into a dedicated method. r=#devtools

This will help then reuse this logic for regular rules.

Comment 2

[Alexandre Poirot [:ochameau] PTO, back August 11th]

Attachment: Bug 2018538 - [devtools] Always use a container in the rule view. r=#devtools

This will help maintain the rule list on CSSOM updates.

Comment 3

[Alexandre Poirot [:ochameau] PTO, back August 11th]

Attachment: Bug 2018538 - [devtools] Simplify a few things around CssRuleView.selectElement. r=#devtools

• simplify fetching pseudoClassLocks as ElementStyle.element is actually equal to this.viewedElement
• which also help remove #clearPseudoClassLocks and only rely on the refresh one.
  refreshPseudoClassPanel doesn't need to wait for this.elementStyle,
  but is functional as soon as viewedElement is set.
• streamline the pattern of having "refresh" methods that can be called
  right after updating the viewedElement both when it is set to a value
  or null.
• #clear argument wasn't used and the method is overall confusing.
  Callsites are clearer by inlined it and using refresh methods.
  (the destroy of ElementStyle is going to be tweaked in followups)

Comment 4

[Alexandre Poirot [:ochameau] PTO, back August 11th]

Attachment: Bug 2018538 - [devtools] Use a more explicit name for the selected element node front. r=#devtools

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b46e96f6ffa3
https://hg.mozilla.org/integration/autoland/rev/00788d76a7fa
[devtools] Simplify a few things around CssRuleView.selectElement. r=devtools-reviewers,nchevobbe
https://github.com/mozilla-firefox/firefox/commit/90e830b03f1e
https://hg.mozilla.org/integration/autoland/rev/d660180beb2a
[devtools] Use a more explicit name for the selected element node front. r=devtools-reviewers,nchevobbe
https://github.com/mozilla-firefox/firefox/commit/e24f8373ca04
https://hg.mozilla.org/integration/autoland/rev/bee11d4678c3
[devtools] RuleEditor: Factorize all container logic into a dedicated method. r=devtools-reviewers,nchevobbe
https://github.com/mozilla-firefox/firefox/commit/e10bc3fd75de
https://hg.mozilla.org/integration/autoland/rev/4a499a60cca5
[devtools] Always use a container in the rule view. r=devtools-reviewers,nchevobbe

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/00788d76a7fa
https://hg.mozilla.org/mozilla-central/rev/d660180beb2a
https://hg.mozilla.org/mozilla-central/rev/bee11d4678c3
https://hg.mozilla.org/mozilla-central/rev/4a499a60cca5