2018611 - Add "userContext" to certain WebDriver BiDi events and commands

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Via https://github.com/w3c/webdriver-bidi/pull/1046 we got the userContext field added to WebDriver BiDi events. For now these are optional but will be turned to required once all browser releases support this field.

We should add the userContext field and if needed as well update the WebDriver BiDi tests if Jim is not able to do it himself.

Comment 1

[Julian Descottes [:jdescottes]]

Note: on top of events we also need to add userContext to the return value of browsingContext.create which was also modified by https://github.com/w3c/webdriver-bidi/pull/1046

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 2018611 - [bidi] Add userContext to script.Source

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 2018611 - [bidi] Add userContext to script.WindowRealmInfo

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 2018611 - [bidi] Add userContext to input.FileDialogInfo

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 2018611 - [bidi] Add userContext to browsingContext.CreateResult

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 2018611 - [bidi] Add userContext to browsingContext events

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 2018611 - [bidi] Add userContext to network events

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 2018611 - [wdspec] Add tests for userContext field in events

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/184d84fa3a20
https://hg.mozilla.org/integration/autoland/rev/6a0264e52fdd
[bidi] Add userContext to script.Source r=Sasha
https://github.com/mozilla-firefox/firefox/commit/8e90be927fe0
https://hg.mozilla.org/integration/autoland/rev/798efffbcafd
[bidi] Add userContext to script.WindowRealmInfo r=Sasha
https://github.com/mozilla-firefox/firefox/commit/1918560b6bdd
https://hg.mozilla.org/integration/autoland/rev/37e577845e86
[bidi] Add userContext to input.FileDialogInfo r=Sasha
https://github.com/mozilla-firefox/firefox/commit/4a2490273884
https://hg.mozilla.org/integration/autoland/rev/d2a2bef50938
[bidi] Add userContext to browsingContext.CreateResult r=Sasha
https://github.com/mozilla-firefox/firefox/commit/c0f423715bcf
https://hg.mozilla.org/integration/autoland/rev/693e37f90885
[bidi] Add userContext to browsingContext events r=Sasha
https://github.com/mozilla-firefox/firefox/commit/675bedd8a591
https://hg.mozilla.org/integration/autoland/rev/ffe58fe58e60
[bidi] Add userContext to network events r=Sasha
https://github.com/mozilla-firefox/firefox/commit/1d8727ee428a
https://hg.mozilla.org/integration/autoland/rev/61f236f3c95d
[wdspec] Add tests for userContext field in events r=Sasha

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60701 for changes under testing/web-platform/tests

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6a0264e52fdd
https://hg.mozilla.org/mozilla-central/rev/798efffbcafd
https://hg.mozilla.org/mozilla-central/rev/37e577845e86
https://hg.mozilla.org/mozilla-central/rev/d2a2bef50938
https://hg.mozilla.org/mozilla-central/rev/693e37f90885
https://hg.mozilla.org/mozilla-central/rev/ffe58fe58e60
https://hg.mozilla.org/mozilla-central/rev/61f236f3c95d

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot