Closed Bug 2018654 Opened 2 months ago Closed 2 months ago

Merge automation decision tasks are failing on esr140

Categories

(Release Engineering :: Release Automation, defect)

defect

Tracking

(firefox-esr140 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr140 --- fixed

People

(Reporter: eijebong, Assigned: eijebong)

References

Details

Attachments

(1 file)

I messed up with the uplift because release_level was changed to accept the whole params object instead of just the project and I guess I botched my testing...

[task 2026-02-23T16:00:17.585Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/mark_as_merged.py", line 26, in make_task_description
[task 2026-02-23T16:00:17.585Z]     **{"release-level": release_level(config.params)},
[task 2026-02-23T16:00:17.585Z]                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2026-02-23T16:00:17.585Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/util/attributes.py", line 139, in release_level
[task 2026-02-23T16:00:17.585Z]     return "production" if project in RELEASE_PROJECTS else "staging"
[task 2026-02-23T16:00:17.585Z]                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2026-02-23T16:00:17.585Z] TypeError: unhashable type: 'Parameters'
See Also: → 1890753

When I uplifted bug 1890753 to esr140 I missed that release_level had
changed from accepting the project name to full params between esr140
and main which made this decision task fail since it got a Parameters
instead of a string. Fixing that was also not enough since we were
also passing run-on-repo-type which makes no sense on this branch...

Attachment #9547249 - Flags: approval-mozilla-esr140?

firefox-esr140 Uplift Approval Request

  • User impact if declined: This is blocking merge automation on esr140
  • Code covered by automated testing: no
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Can't be more broken than it already is. Change is limited to merge automation
  • String changes made/needed: N/A
  • Is Android affected?: no
Attachment #9547249 - Flags: approval-mozilla-esr140? → approval-mozilla-esr140+
Regressions: 2018744
No longer regressions: 2018744
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: