Closed
Bug 2018705
Opened 7 months ago
Closed 2 months ago
Migrate Sections unit test to Jest/RTL
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
155 Branch
| Tracking | Status | |
|---|---|---|
| firefox155 | --- | fixed |
People
(Reporter: maxx, Assigned: thecount)
References
Details
Attachments
(1 file, 2 obsolete files)
Migrate the Section component tests covering impression stats dispatching, visibility change events, and the sendNewTabRehydrated
flow (now using componentDidMount/componentDidUpdate after the React 19 lifecycle fixes).
Updated tests:
- test/unit/content-src/components/Sections.test.jsx
| Reporter | ||
Updated•7 months ago
|
Summary: Upgrade Sections to Jest/RTL → Migrate Sections unit test to Jest/RTL
| Reporter | ||
Comment 1•7 months ago
|
||
Migrates Sections.test.jsx from Enzyme/Karma to React Testing Library/Jest,
covering _Sections and Section.
- Adds test/unit/jest/content-src/components/Sections.test.jsx with 25 tests
- Tests use data-section-id attribute for section ordering assertions
- Replaces sinon.spy/stub with jest.fn() and wrapper.setProps with rerender
- Replaces instance().numRows checks with observable card count assertions
- Marks test/unit/content-src/components/Sections.test.jsx with
@enzyme-to-rtl comment
Updated•6 months ago
|
Attachment #9547561 -
Attachment is obsolete: true
| Assignee | ||
Comment 2•2 months ago
|
||
Updated•2 months ago
|
Assignee: nobody → sdowne
Status: NEW → ASSIGNED
Comment 3•2 months ago
|
||
Updated•2 months ago
|
Attachment #9618738 -
Attachment description: WIP: Bug 2018705 - Migrate Sections unit test to Jest/RTL → WIP: Bug 2018705 - Migrate Sections unit test to Jest/RTL. r?thecount
Updated•2 months ago
|
Attachment #9618738 -
Attachment description: WIP: Bug 2018705 - Migrate Sections unit test to Jest/RTL. r?thecount → WIP: Bug 2018705 - Migrate Sections unit test to Jest/RTL. r=#home-newtab-reviewers
Updated•2 months ago
|
Attachment #9618738 -
Attachment description: WIP: Bug 2018705 - Migrate Sections unit test to Jest/RTL. r=#home-newtab-reviewers → Bug 2018705 - Migrate Sections unit test to Jest/RTL. r=#home-newtab-reviewers
Pushed by sdowne@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/6ad0a49d2425
https://hg.mozilla.org/integration/autoland/rev/b7dda7c677c2
Migrate Sections unit test to Jest/RTL.
Comment 5•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox155:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
| Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c156/b155]
Updated•19 days ago
|
Attachment #9618708 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•