2018708 - Migrate TopSites unit tests to Jest/RTL

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

Migrate the large TopSites container test suite covering drag-and-drop interactions, keyboard navigation, Redux state changes, and
sponsored/search shortcut top site behaviors.

Updated tests:

• test/unit/content-src/components/TopSites.test.jsx
• test/unit/content-src/components/TopSites/SearchShortcutsForm.test.jsx
• test/unit/content-src/components/TopSites/TopSiteImpressionWrapper.test.jsx

Comment 1

[Maxx Crawford [:maxx]]

Attachment: WIP: Bug 2018708 - Add RTL/Jest tests for TopSites components

Migrates TopSites.test.jsx, SearchShortcutsForm.test.jsx, and
TopSiteImpressionWrapper.test.jsx from Enzyme/Karma to React Testing
Library/Jest.

• Adds test/unit/jest/content-src/components/TopSites.test.jsx with 53 tests
  covering TopSites, TopSiteLink, TopSite, TopSiteForm, TopSiteFormInput,
  TopSiteList, and TopSiteAddButton
• Adds test/unit/jest/content-src/components/TopSites/SearchShortcutsForm.test.jsx
  with 3 tests
• Adds test/unit/jest/content-src/components/TopSites/TopSiteImpressionWrapper.test.jsx
  with 6 tests
• Uses Redux Provider with createStore for components with connected children
• Replaces wrapper.instance() calls for internal methods (_allowDrop,
  onDragEvent, validateUrl, etc.) with observable DOM assertions; drag-and-drop
  and keyboard navigation tests are omitted as implementation details
• Marks all three Enzyme files with @enzyme-to-rtl comments

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 2018708 - Migrate TopSites unit tests from Enzyme/Karma to Jest/RTL.

Comment 3

[Reem Hamoui]

Attachment: Bug 2018708 - Migrate TopSites unit tests to Jest/RTL. r?reemhamz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1a63eb64ee39
https://hg.mozilla.org/integration/autoland/rev/5d28fee1167f
Migrate TopSites unit tests to Jest/RTL. r=reemhamz

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5d28fee1167f