201881 - disable more commands when opening messegae/rfc822 attachment in stand alone msg window

Status: RESOLVED WONTFIX

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

from bug #143565:

disable more comments when opening rfc/822 attachment in stand alone msg window

1) we should disable Message | Move and Message | Copy menu items
2) right click on the message body, there's a bunch we should disable there

Comment 1

[Antonio.Xu]

Attachment: patch version 1.0

Those two issues can be solved by this patch.

Comment 2

[[e-mail]]

Comment on attachment 120414 [details] [diff] [review]
patch version 1.0

Doesn't this disable too many context menu items? Actually how I would like to
see this fixed is to use the msgMail3PaneWindow.js version of
GetFirstSelectedMessage for all windows (move it into mailWindowOverlay.js?),
then those functions that need a real message use that and those functions that
need the loaded message or attachment can use GetLoadedMessage().

Comment 3

[Antonio.Xu]

Attachment: patch version 1.1

create new patch according to Neil's advice.

Comment 4

[[e-mail]]

Comment on attachment 120567 [details] [diff] [review]
patch version 1.1

>Index: mailnews/base/resources/content/mailContextMenus.js
>===================================================================
>RCS file: /cvsroot/mozilla/mailnews/base/resources/content/mailContextMenus.js,v
>retrieving revision 1.40
>diff -u -r1.40 mailContextMenus.js
>--- mailnews/base/resources/content/mailContextMenus.js	18 Mar 2003 19:33:28 -0000	1.40
>+++ mailnews/base/resources/content/mailContextMenus.js	15 Apr 2003 13:17:36 -0000
>@@ -446,7 +448,7 @@
>   SetupLabelsMenuItem("messagePaneContext-labels", numSelected, (numSelected == 0 || hideMailItems));
>   SetupMarkMenuItem("messagePaneContext-mark", numSelected, (numSelected == 0 || hideMailItems));
>   SetupSaveAsMenuItem("messagePaneContext-saveAs", numSelected, (numSelected == 0 || hideMailItems));
>-  SetupPrintMenuItem("messagePaneContext-print", numSelected, (numSelected == 0 || hideMailItems));
>+  SetupPrintMenuItem("messagePaneContext-print", ((message) ? 1 : 0), ((numSelected == 0 && !message) || hideMailItems));
Do you need numSelected == 0 && !message here?
I would guess that !message works on its own...

Comment 5

[Matthias Versen [:Matti]]

Comment on attachment 120414 [details] [diff] [review]
patch version 1.0

clearing obsolete review requests

Comment 6

[:aceman]

May bug 204350 be relevant?

Comment 7

[WADA:World Anti-bad-Duping Agency]

Change 'rfc/822' in summary to 'message/rfc822' for ease of search.

Comment 8

[Martijn Coppoolse]

May I ask that this bug's status be changed to WONTFIX?
I mean, looking at the number of votes for bug 204350, all of the options
mentioned here should be ENabled, not disabled.

Comment 9

[Mike Cowperthwaite]

The new patch at bug 204350 is progress in the opposite direction indicated by this bug: more functions are getting enabled.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 120567 [details] [diff] [review]
patch version 1.1

I've just verified that all the options that are currently presented do actually work.

As this bug has also long ago been marked wontfix, cancelling review request on the patch as it doesn't seem necessary any more.