Update "Open Link in Split View" context menu option to open a split view with a tab for the link and a tab for the existing page you were on when opening the link
Categories
(Firefox :: Tabbed Browser: Split View, task, P1)
Tracking
()
People
(Reporter: kcochrane, Assigned: kcochrane)
References
(Blocks 4 open bugs)
Details
(Whiteboard: [fidefe-splitview])
Attachments
(2 files, 3 obsolete files)
In bug 2002328, we added a new context menu option for links to "Open Link in Split View". We set this new option up to open a new split view with a tab for the link and the about:opentabs page, but what we actually need is for the option to open a split view with a tab for the link and a tab for the existing page you were on when opening the link.
|
||
Updated•4 months ago
|
|
Assignee | |
Updated•4 months ago
|
|
|
Assignee | |
Comment 2•4 months ago
|
||
|
||
Comment 4•4 months ago
|
||
| bugherder | ||
|
|
||
Comment 5•4 months ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 6•3 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D284702
|
||
Updated•3 months ago
|
|
|
||
Comment 7•3 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: When right clicking a link to open the link in a split view, it will open a new split view with the link and about:opentabs when the expected behavior is it to open a split view with the current tab you were already on and the link.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: Open a page with a link on it
Right click the link and select "Open Link in Split View"
Ensure the split view is created with the original tab and the link you right clicked as the other tab - Risk associated with taking this patch: low
- Explanation of risk level: Small nsContextMenu.sys.mjs change covered by test
- String changes made/needed: N/A
- Is Android affected?: no
I think there's still a problem here. If you use the "open link in split view" when already in a split view (especially right hand side) - things go awry.
|
|
Assignee | |
Comment 9•3 months ago
|
||
Looking into this now, thanks :jonrandy
|
|
Assignee | |
Comment 10•3 months ago
|
||
Given we're hoping to uplift this to 149 beta, we're going to hide this "Open Link in Split View" option if the link is on a page that is already part of an existing split view. I will make a follow-up bug for potentially showing a different option in this scenario such as "Open Link in Left/Right View" (whichever is opposite the page with the link), but it needs further discussion with UX/Product.
|
|
Assignee | |
Comment 11•3 months ago
|
||
|
||
Comment 12•3 months ago
|
||
Reproduced the issue with Firefox 150.a01 (20260224034324) on Windows 11. The Open link in Split View context menu option will open the about:opentabs page.
The issue is verified fixed with Firefox 150.0a1 (2025-03-05) on Windows 11, macOS 26 and Ubuntu 24. After following the steps from comment 7 the Split View is created with the original tab and the link that was right-clicked as the other tab.
I will also verify the patch from comment 11 after it lands. Thank you!
|
|
Assignee | |
Comment 13•3 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D286284
|
|
||
Updated•3 months ago
|
|
|
||
Comment 14•3 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: Using the "Open Link in Split View" for a link on a page within an existing split view will cause unexpected results
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: Ensure "Open Link in Split View" option is hidden if right clicking a link on a page that is part of an existing split view
- Risk associated with taking this patch: low
- Explanation of risk level: Small change in nsContextMenu.sys.mjs that is covered by a new test
- String changes made/needed: N/A
- Is Android affected?: no
|
|
||
Updated•3 months ago
|
|
|
||
Updated•3 months ago
|
|
||
Comment 15•3 months ago
|
||
The patches in this bug failed to land as they need rebasing.
|
||
Comment 16•3 months ago
|
||
|
||
Updated•3 months ago
|
|
|
||
Comment 18•3 months ago
|
||
| uplift | ||
|
|
Assignee | |
Comment 19•3 months ago
•
|
||
Bryan, it looks like uplifting this stack of patches here would also require a beta uplift for bug 2002328. That patch includes a new string for "Open Link in Split View". Is it too late in beta for that new string to be localized properly?
|
|
Assignee | |
Updated•3 months ago
|
|
|
||
Comment 20•3 months ago
|
||
| uplift | ||
|
||
Comment 21•3 months ago
|
||
In the meantime, I backed this out of beta but it can land again one a decision has been made. It can land again tomorrow if needed.
|
|
||
Updated•3 months ago
|
|
||
Comment 22•3 months ago
|
||
Hi folks,
Just adding context here in one comment:
While trying to uplift this very helpful functional patch (improving the behavior of opening links from a single-pane split view in the second pane), we realized that the earlier patch that introduced the string Open link in Split View didn’t make 149.
This functional patch will help a lot with the discoverability of the Split View feature in 149, but we, of course, understand that string freeze exists for a reason. We peeked at the existing translations for the string, and it looks like we may be in a reasonable shape to consider an uplift, since most of our top locales are covered (Portuguese and Bahasa Indonesian being too most noticeable exceptions). Do you think this is a reasonable approach?
|
||
Comment 23•3 months ago
|
||
Hi, it’s in a quite visible space but we landed this string soon after string freeze. There’s a risk the string will appear untranslated for some locales, but I’ll approve an uplift. Just confirming its the one string main-context-menu-open-link-split-view that's being uplfited?
|
|
||
Comment 24•3 months ago
|
||
Yes, that's right, that's the right.
Kelly, please correct me if I'm wrong!
|
|
Assignee | |
Comment 25•3 months ago
|
||
|
|
||
Updated•3 months ago
|
|
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 26•3 months ago
|
||
(In reply to Bryan Olsson [:bolsson] from comment #23)
Hi, it’s in a quite visible space but we landed this string soon after string freeze. There’s a risk the string will appear untranslated for some locales, but I’ll approve an uplift. Just confirming its the one string
main-context-menu-open-link-split-viewthat's being uplfited?
Correct! Just the one new string
|
||
Comment 27•3 months ago
|
||
| bugherder | ||
|
|
||
Comment 28•3 months ago
•
|
||
(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #12)
Reproduced the issue with Firefox 150.a01 (20260224034324) on Windows 11. The
Open link in Split Viewcontext menu option will open the about:opentabs page.
The issue is verified fixed with Firefox 150.0a1 (2025-03-05) on Windows 11, macOS 26 and Ubuntu 24. After following the steps from comment 7 the Split View is created with the original tab and the link that was right-clicked as the other tab.
I will also verify the patch from comment 11 after it lands. Thank you!
Verified that the Open link is Split View context menu option is no longer displayed while already in a Split View. Testing was performed with Firefox 150.0a1 (2026-03-05) on Windows 11, macOS 26 and Ubuntu 24.
|
||
Comment 29•3 months ago
|
||
A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)
|
|
||
Comment 30•3 months ago
|
||
Spoke with Kelly and we will wait for Bug 2021566 to be fixed before attempting uplifting them together again to beta or a dot release.
|
|
||
Updated•3 months ago
|
|
|
||
Updated•3 months ago
|
|
||
Updated•2 months ago
|
Description
•