2019013 - Cleanup geckoview service definitions

Status: RESOLVED FIXED

(GeckoView :: General, task)

Description

[Ted Campbell [:tcampbell]]

I want to cleanup the <service> definitions in Geckoview:

• move the singleton services to the jinja file so there are less places to look. also gives more flexibility to make things configurable in future
• only have a single isolatedTabWithZygote (instead of 40)

This should make things like Bug 2005825 a bit cleaner too

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 2019013 - Put GeckoView service definitions in one place. r?#geckoview-reviewers

Declare all the <service> blocks in the jinja template instead of spreading
across multiple files. This also makes it easier in the future to configure the
singleton services in other ways.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 2019013 - Declare only a single GV isolated-zygote service. r?#geckoview-reviewers

Using zygote mode uses dynamic service names, so avoid generating more than
one. Also name the service zygoteTab to shorten it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/83a37b19621e
https://hg.mozilla.org/integration/autoland/rev/0c7551ca7e40
Put GeckoView service definitions in one place. r=geckoview-reviewers,ohall
https://github.com/mozilla-firefox/firefox/commit/b824864d692f
https://hg.mozilla.org/integration/autoland/rev/2fff11a001a4
Declare only a single GV isolated-zygote service. r=geckoview-reviewers,ohall

Comment 4

[rperta]

https://hg.mozilla.org/mozilla-central/rev/0c7551ca7e40
https://hg.mozilla.org/mozilla-central/rev/2fff11a001a4